From: Louis Rilling <l.rilling@av7.net>
To: Jameson Graef Rollins <jrollins@finestructure.net>
Cc: notmuch@notmuchmail.org, Thomas Schwinge <thomas@schwinge.name>
Subject: Re: [PATCH] notmuch restore --accumulate
Date: Fri, 9 Sep 2011 11:06:34 +0200 [thread overview]
Message-ID: <20110909090633.GA3178@localdomain> (raw)
In-Reply-To: <87liu2kcq6.fsf@servo.factory.finestructure.net>
On 05/09/11 12:31 -0700, Jameson Graef Rollins wrote:
> Also, we generally prefer to have modifications to the test suite in
> separate patches that precede the patches that add the features/fix the
> bugs.
>
For new features, this does not look like 'git bisect'-safe. I would say that
the testsuite patch should follow the new feature patch, don't you?
Thanks,
Louis
> > Signed-off-by: Thomas Schwinge <thomas@schwinge.name>
>
> Finally, you don't need to sign off on your own patches.
>
> Thanks.
>
> jamie.
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2011-09-09 9:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 19:07 [PATCH] notmuch restore --accumulate Thomas Schwinge
2011-09-05 19:31 ` Jameson Graef Rollins
2011-09-09 9:06 ` Louis Rilling [this message]
2011-09-09 9:45 ` Thomas Schwinge
2011-09-09 16:13 ` Austin Clements
2011-09-09 17:22 ` Thomas Schwinge
2011-09-09 17:35 ` Austin Clements
2011-09-09 18:58 ` Jameson Graef Rollins
2011-09-29 18:24 ` [PATCH] patchformatting: Test Suite Enhancements Thomas Schwinge
2011-09-29 17:36 ` [PATCH, v2] notmuch restore --accumulate Thomas Schwinge
2011-09-29 17:37 ` Thomas Schwinge
2011-10-21 19:47 ` Updated v3 patches for " David Bremner
2011-10-21 19:47 ` [PATCH 1/6] test/test-lib.sh: update comments David Bremner
2011-10-21 19:47 ` [PATCH 2/6] test/dump-restore: expand test suite for dump-restore, make more robust David Bremner
2011-10-21 19:47 ` [PATCH 3/6] test/dump-restore: add tests for restore --accumulate David Bremner
2011-10-21 19:47 ` [PATCH 4/6] notmuch-restore: implement --accumulate option David Bremner
2011-10-21 19:47 ` [PATCH 5/6] test/dump-restore: Fix quoting on grep David Bremner
2011-10-21 19:47 ` [PATCH 6/6] notmuch-restore: check for extra arguments David Bremner
2011-10-21 22:21 ` [PATCH 1/2] notmuch.1: typo fixes new wording for dump/restore David Bremner
2011-10-21 22:21 ` [PATCH 2/2] docs: Update news, man page, and online help for restore --accumulate David Bremner
2011-10-23 19:50 ` Updated v3 patches for notmuch " David Bremner
2011-10-16 21:48 ` [PATCH, v2] " David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909090633.GA3178@localdomain \
--to=l.rilling@av7.net \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).