From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 21390429E27 for ; Thu, 1 Sep 2011 03:50:26 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.001 X-Spam-Level: X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 tests=[FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6USJP0yz5o5I for ; Thu, 1 Sep 2011 03:50:24 -0700 (PDT) Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by olra.theworths.org (Postfix) with ESMTP id 0F542429E26 for ; Thu, 1 Sep 2011 03:50:22 -0700 (PDT) Received: from coriolan (unknown [88.172.133.112]) by smtp2-g21.free.fr (Postfix) with ESMTP id 81B654B006D for ; Thu, 1 Sep 2011 12:50:11 +0200 (CEST) Date: Thu, 1 Sep 2011 12:49:51 +0200 From: =?UTF-8?B?RnJhbsOnb2lz?= Gannaz To: notmuch@notmuchmail.org Subject: Re: Patch formatting Message-ID: <20110901124951.2f6420b1@coriolan> In-Reply-To: References: X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.4; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2011 10:50:26 -0000 Hi On 2011-09-01, Tomi Ollila wrote: > Hi >=20 > Please check (now updated) >=20 > http://notmuchmail.org/patchformatting/ >=20 > page. >=20 >=20 > Anything that can me used to improve the content (even furtner!) > are greatly appreciated. A few minor suggestions: * Insert a link for the text "Software Release Practice HOWTO" http://tldp.org/HOWTO/Software-Release-Practice-HOWTO/ * s/If you're made/If you've made/ * s/and you'll get/and you get/ * Also replace: git format patch commit-sha1(-prefix) by git format patch * s/to To: field/into To: field/ I also suggest that you insert at the beginning a simple use case: # Please commit clean changes (see details in section "Committing") $ git commit | One line descr | | Long descr # Check which commits to send $ git log # Prepare patches after 1f77... $ git format patch 1f727c65ed864c4cdbb43456b5c8f130f69a193d # Send to mailing list (test) $ send-email --dry-run --compose 00*.patch # Send to mailing list $ send-email --compose 00*.patch -- Fran=C3=A7ois