From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3DA7B431FD0 for ; Tue, 12 Jul 2011 06:48:07 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ag3m++hEzGqd for ; Tue, 12 Jul 2011 06:48:06 -0700 (PDT) Received: from mail-ew0-f53.google.com (mail-ew0-f53.google.com [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id BD7AB431FB6 for ; Tue, 12 Jul 2011 06:48:05 -0700 (PDT) Received: by ewy8 with SMTP id 8so1741776ewy.26 for ; Tue, 12 Jul 2011 06:48:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=7HCwWVSb2fYfFtte3ALBWYkUpy7/Tod/IsnQr12JcIw=; b=Id1WeTB+AafSkb4sHw4i8yflpwubJPN//m74o565rS2t1/TTrjjwYiaTkLV3xeNapP YuwInclyaQCOEhVUqZ5sRzrRRhXlI5SYLf0Oso8PYhxSJLU6fQf+7Ln9om87ZYPwLGsq c5h7qn2YGa2wEBER9RfQylrRHBNeV05qWgBDg= Received: by 10.213.8.4 with SMTP id f4mr1353313ebf.142.1310478484060; Tue, 12 Jul 2011 06:48:04 -0700 (PDT) Received: from localdomain ([78.222.14.116]) by mx.google.com with ESMTPS id b9sm1533669een.42.2011.07.12.06.48.02 (version=SSLv3 cipher=OTHER); Tue, 12 Jul 2011 06:48:03 -0700 (PDT) Sender: Louis Rilling Date: Tue, 12 Jul 2011 15:47:56 +0200 From: Louis Rilling To: Austin Clements Subject: Re: [PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags change Message-ID: <20110712134755.GA3279@localdomain> References: <87d3hzgemi.fsf@yoom.home.cworth.org> <1310394978-11883-3-git-send-email-l.rilling@av7.net> <20110711200712.GB25558@mit.edu> <20110711223805.GC3583@localdomain> <20110712000344.GD25558@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110712000344.GD25558@mit.edu> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2011 13:48:07 -0000 On 11/07/11 20:03 -0400, Austin Clements wrote: > > > The convention in notmuch is to use notmuch_bool_t, TRUE, and FALSE > > > (though, admittedly, I don't know why; avoiding C99-isms?) > > > > And bool is already used at another place in message.cc: > > > > struct maildir_flag_tag { > > char flag; > > const char *tag; > > bool inverse; > > }; > > > > IIUC it should be changed to notmuch_bool_t too. > > Yes, I suppose it should (something slipped by cworth's eagle-eyed > reviews!). Though that appears to be the sole use of bool in all of > libnotmuch. I wonder if this is due to incompatible definitions of type bool in C99 and C++. In that case this is probably harmless since struct maildir_flag_tag is only visible from message.cc. Anyway, I'm sending a conversion patch together with the updated series to make it clearer for Carl. Thanks, Louis