From: Austin Clements <amdragon@MIT.EDU>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] Add dir-locals style variables for C++ and Elisp code.
Date: Tue, 7 Jun 2011 02:57:54 -0400 [thread overview]
Message-ID: <20110607065754.GH29861@mit.edu> (raw)
In-Reply-To: <87d3iqp5wk.fsf@gmail.com>
Quoth Dmitry Kurochkin on Jun 07 at 9:27 am:
> Hi Austin.
>
> On Tue, 7 Jun 2011 01:20:25 -0400, Austin Clements <amdragon@MIT.EDU> wrote:
> > Also, slightly reformat dir-locals.el so that the settings align and
> > to make it friendlier for future additions.
> > ---
> > .dir-locals.el | 18 ++++++++++++++----
> > 1 files changed, 14 insertions(+), 4 deletions(-)
> >
> > diff --git a/.dir-locals.el b/.dir-locals.el
> > index cbdb1f9..eff29fc 100644
> > --- a/.dir-locals.el
> > +++ b/.dir-locals.el
> > @@ -1,7 +1,17 @@
> > ; emacs local configuration settings for notmuch source
> > ; surmised by dkg on 2010-11-23 13:43:18-0500
> > +; amended by amdragon on 2011-06-06
> >
> > -((c-mode . ((indent-tabs-mode . t)
> > - (tab-width . 8)
> > - (c-basic-offset . 4)
> > - (c-file-style . "linux"))))
> > +((c-mode
> > + (indent-tabs-mode . t)
> > + (tab-width . 8)
> > + (c-basic-offset . 4)
> > + (c-file-style . "linux"))
> > + (c++-mode
> > + (indent-tabs-mode . t)
> > + (tab-width . 8)
> > + (c-basic-offset . 4)
> > + (c-file-style . "linux"))
> > + (emacs-lisp-mode
> > + (indent-tabs-mode . t))
> > + )
>
> Why tab-width is not set for the emacs-lisp-mode?
Because I forgot to set it. ]:--8)
> Also, perhaps we should set these variables for all modes? Setting
> c-basic-offset and c-file-style should not hurt. And indent-tabs-mode
> and tab-width should be relevant for any file in notmuch (shell, python,
> probably even text files), no?
Personally, I would prefer to keep .dir-locals conservative, rather
than make sweeping settings. For example, the Python code isn't (and
definitely shouldn't be) using tabs. Adding settings for shell is a
good idea, though.
> Regards,
> Dmitry
next prev parent reply other threads:[~2011-06-07 6:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 5:20 [PATCH] Add dir-locals style variables for C++ and Elisp code Austin Clements
2011-06-07 5:27 ` Dmitry Kurochkin
2011-06-07 6:57 ` Austin Clements [this message]
2011-06-07 6:38 ` Dima Kogan
2011-06-07 7:00 ` Austin Clements
2011-06-10 1:28 ` [PATCH] Add dir-locals style variables for C++, Elisp, and shell code Austin Clements
2011-06-24 0:03 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607065754.GH29861@mit.edu \
--to=amdragon@mit.edu \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).