From: Austin Clements <amdragon@MIT.EDU>
To: notmuch@notmuchmail.org
Subject: Re: [RFC PATCH v2 0/8] Custom query parser, date search, folder search, and more
Date: Wed, 2 Feb 2011 00:03:37 -0500 [thread overview]
Message-ID: <20110202050336.GB28537@mit.edu> (raw)
In-Reply-To: <1295165458-9573-1-git-send-email-amdragon@mit.edu>
I rebased the query parser against current master. It's on the
qparser-3 branch at
http://awakening.csail.mit.edu/git/notmuch.git
At cworth's request, I've folded the database closing bug fix in to
the appropriate patch. I also stripped out my implementation of
folder searching, since it obviously conflicts with cworth's [1]. I'm
not planning to resend the patches unless asked because there were no
actual code changes.
[1] I still assert the "correct" folder solution is somewhere between
mine and cworth's: rooted and non-recursive by default (non-recursive
is the only thing that makes sense for Maildir++ folders and it would
be silly for the default to depend on folder type), but leveraging the
flexibility of custom query transforms to support Maildir++ folders
and recursive (and maybe non-rooted) searches as well. Non-rooted and
recursive searches even map to natural syntaxes that align with
Xapian's existing wildcard syntax.
Quoth myself on Jan 16 at 3:10 am:
> This is version 2 of the custom query parser. It now supports date
> searches with sane syntax, folder searches (without any additions or
> changes to the database, unlike cworth's recent commit), and "tag:*"
> and "-tag:*" queries for finding tagged and untagged messages. I used
> these features to guide changes to the original design and to validate
> the approach. This is still RFC, but it's much less raw now.
>
> In addition to the new features, the core query parser has a bunch of
> cleanups and changes, including completely redone NEAR and ADJ
> operators that now behave essentially the same as they do in Xapian's
> query parser. I also split the implementation of these out into a
> separate patch for ease of review.
>
> There's a notable lack of tests in this current series. I do have a
> pile of tests for the lexer, parser, and generator, but the
> infrastructure for testing them needs cleanup before I send that out.
>
--
Austin Clements MIT/'06/PhD/CSAIL
amdragon@mit.edu http://web.mit.edu/amdragon
Somewhere in the dream we call reality you will find me,
searching for the reality we call dreams.
next prev parent reply other threads:[~2011-02-02 5:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 8:10 [RFC PATCH v2 0/8] Custom query parser, date search, folder search, and more Austin Clements
2011-01-16 8:10 ` [PATCH 1/8] Implement a custom query parser with a mostly Xapian-compatible grammar Austin Clements
2011-01-21 6:37 ` [PATCH 1.5/8] Query parser testing framework and basic tests Austin Clements
2011-01-16 8:10 ` [PATCH 2/8] Parse NEAR and ADJ operators Austin Clements
2011-01-21 6:39 ` [PATCH 2.5/8] Query parser tests for " Austin Clements
2011-01-16 8:10 ` [PATCH 3/8] Parse wildcard queries Austin Clements
2011-01-21 6:40 ` [PATCH 3.5/8] Query parser tests for " Austin Clements
2011-01-22 16:47 ` Michal Sojka
2011-01-23 22:02 ` Austin Clements
2011-01-24 12:24 ` Michal Sojka
2011-01-16 8:10 ` [PATCH 4/8] Replace Xapian query parser with custom query parser Austin Clements
2011-01-16 8:10 ` [PATCH 5/8] Support "tag:*" as well as "NOT tag:*" queries Austin Clements
2011-01-24 17:15 ` [PATCH 5.5/8] test: Wildcard tag search and untagged search Austin Clements
2011-01-16 8:10 ` [PATCH 6/8] Support maildir folder search Austin Clements
2011-01-24 17:13 ` [PATCH 6/8 v2] " Austin Clements
2011-01-24 17:18 ` [PATCH 6.5/8] test: Add tests for custom query parser-based folder searches Austin Clements
2011-01-16 8:10 ` [PATCH 7/8] Implement value range queries Austin Clements
2011-01-16 8:10 ` [PATCH 8/8] Support before: and after: date search with sane date syntax Austin Clements
2011-01-24 17:20 ` [PATCH 8.5/8] test: Add tests for search by date Austin Clements
2011-01-31 4:33 ` [PATCH 9/8] qparser: Delete (and thus close) the Xapian database Austin Clements
2011-02-02 5:03 ` Austin Clements [this message]
2011-02-02 22:48 ` [RFC PATCH v2 0/8] Custom query parser, date search, folder search, and more Carl Worth
2011-02-03 6:14 ` Folder search semantics (was Re: [RFC PATCH v2 0/8] Custom query parser, date search, folder search, and more) Austin Clements
2011-02-20 19:52 ` Folder search semantics Rob Browning
2011-02-20 20:00 ` Rob Browning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110202050336.GB28537@mit.edu \
--to=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).