From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 78C6A4196F4 for ; Thu, 13 May 2010 20:34:49 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h4KI7L2O9EQv for ; Thu, 13 May 2010 20:34:39 -0700 (PDT) Received: from mail-qy0-f184.google.com (mail-qy0-f184.google.com [209.85.221.184]) by olra.theworths.org (Postfix) with ESMTP id EFEDE4196F0 for ; Thu, 13 May 2010 20:34:38 -0700 (PDT) Received: by qyk14 with SMTP id 14so33043qyk.26 for ; Thu, 13 May 2010 20:34:38 -0700 (PDT) Received: by 10.224.94.83 with SMTP id y19mr245461qam.71.1273808078233; Thu, 13 May 2010 20:34:38 -0700 (PDT) Received: from PHANATIQUE.MIT.EDU (c-71-192-160-118.hsd1.nh.comcast.net [71.192.160.118]) by mx.google.com with ESMTPS id 22sm1207252qyk.2.2010.05.13.20.34.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 13 May 2010 20:34:36 -0700 (PDT) Date: Thu, 13 May 2010 23:34:34 -0400 From: Nelson Elhage To: sebastian@sspaeth.de Subject: Re: [PATCH] emacs: notmuch-hello: Use our own keymap. Message-ID: <20100514033434.GA5072@ksplice.com> References: <1273805175-6660-1-git-send-email-nelhage@ksplice.com> <774b5d59b19663f41b4a427c1622f045.squirrel@webmail.sspaeth.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <774b5d59b19663f41b4a427c1622f045.squirrel@webmail.sspaeth.de> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2010 03:34:49 -0000 On Thu, May 13, 2010 at 07:58:38PM -0700, sebastian@sspaeth.de wrote: > > Previously, we were adding our bindings directly to `widget-keymap', > > resulting in them being shared by anything else that used that keymap. > > Is this patch preferable over the one I sent some time ago in > id:1272882573-9864-1-git-send-email-Sebastian@SSpaeth.de ? > > My patch makes notmuch-hello a major mode and also creates the proper > keymap. THe major mode allows the '?' keybinding to also work. > Ah, I failed to properly search the mail archives before sending this. Your patch looks preferable with one exception: I think that making widget-keymap a parent of notmuch-hello-mode-map is probably better than just copying widget-keymap -- if someone defines additional bindings in widget-keymap, we should inherit them whether they are defined before or after notmuch-hello is loaded. (This is also recommended by the documentation for `widget-keymap'). - Nelson