From: Nelson Elhage <nelhage@ksplice.com>
To: sebastian@sspaeth.de
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: notmuch-hello: Use our own keymap.
Date: Thu, 13 May 2010 23:34:34 -0400 [thread overview]
Message-ID: <20100514033434.GA5072@ksplice.com> (raw)
In-Reply-To: <774b5d59b19663f41b4a427c1622f045.squirrel@webmail.sspaeth.de>
On Thu, May 13, 2010 at 07:58:38PM -0700, sebastian@sspaeth.de wrote:
> > Previously, we were adding our bindings directly to `widget-keymap',
> > resulting in them being shared by anything else that used that keymap.
>
> Is this patch preferable over the one I sent some time ago in
> id:1272882573-9864-1-git-send-email-Sebastian@SSpaeth.de ?
>
> My patch makes notmuch-hello a major mode and also creates the proper
> keymap. THe major mode allows the '?' keybinding to also work.
>
Ah, I failed to properly search the mail archives before sending
this. Your patch looks preferable with one exception: I think that
making widget-keymap a parent of notmuch-hello-mode-map is probably
better than just copying widget-keymap -- if someone defines
additional bindings in widget-keymap, we should inherit them whether
they are defined before or after notmuch-hello is loaded. (This is
also recommended by the documentation for `widget-keymap').
- Nelson
next prev parent reply other threads:[~2010-05-14 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 2:46 [PATCH] emacs: notmuch-hello: Use our own keymap Nelson Elhage
2010-05-14 2:58 ` sebastian
2010-05-14 3:34 ` Nelson Elhage [this message]
2010-05-14 16:53 ` Sebastian Spaeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514033434.GA5072@ksplice.com \
--to=nelhage@ksplice.com \
--cc=notmuch@notmuchmail.org \
--cc=sebastian@sspaeth.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).