Re: [PATCH] notmuch: Respect maildir message flags

[martin f krafft <madduck@madduck.net>]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

also sprach Stewart Smith <stewart@flamingspork.com> [2010.02.16.1458 +1300]:
> +	    case 'R': /* replied */
> +		notmuch_message_add_tag (message, "answered");
> +		break;

'r' means replied, not 'answered'.

> +	    case 'T': /* trashed */
> +		notmuch_message_add_tag (message, "deleted");
> +		break;

Same. trashed and deleted are not the same thing.

I don't want to get into an argument over this, because I think this
already exposes a problem: you are putting into global namespace
something not everyone might want, or agree with.

Why not use 'maildirflags::replied' instead? People can always map
that to something in the global namespace.

-- 
martin | http://madduck.net/ | http://two.sentenc.es/
 
"geld ist das brecheisen der macht."
                                                 - friedrich nietzsche
 
spamtraps: madduck.bogus@madduck.net

[-- Attachment #2: Digital signature (see http://martin-krafft.net/gpg/) --]
[-- Type: application/pgp-signature, Size: 198 bytes --]