[PATCH] notmuch-new: Remove the tiresome joke from the output.

[PATCH] notmuch-new: Remove the tiresome joke from the output.

[Chris Wilson]

As I see this every time I poll for new mail, the joke becomes very old
very quickly.  The other instances of "not much" are shown much less
often and have a much more natural style, this one however feels forced,
impairing the humorous effect.

Signed-off-by: Chris "the critic" Wilson <chris@chris-wilson.co.uk>
---
 notmuch-new.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/notmuch-new.c b/notmuch-new.c
index e32b92a..3cde3a7 100644
--- a/notmuch-new.c
+++ b/notmuch-new.c
@@ -483,12 +483,10 @@ notmuch_new_command (void *ctx, int argc, char *argv[])
 	}
     }
     if (add_files_state.added_messages) {
-	printf ("Added %d new %s to the database (not much, really).\n",
+	printf ("Added %d new %s to the database.\n",
 		add_files_state.added_messages,
 		add_files_state.added_messages == 1 ?
 		"message" : "messages");
-    } else {
-	printf ("No new mail---and that's not much.\n");
     }
 
     if (elapsed > 1 && ! add_files_state.saw_read_only_directory) {
-- 
1.6.5.3

Re: [PATCH] notmuch-new: Remove the tiresome joke from the output.

[Carl Worth]

On Tue, 24 Nov 2009 19:41:20 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> As I see this every time I poll for new mail, the joke becomes very old
> very quickly.  The other instances of "not much" are shown much less
> often and have a much more natural style, this one however feels forced,
> impairing the humorous effect.

Fine. My joke wen stale quickly. I'll agree to remove it.

> -    } else {
> -	printf ("No new mail---and that's not much.\n");
>      }

Shouldn't we still print *something* here, though ("No new mail")?
Imagine the new user trying to ensure "notmuch new" is working---and
let's say it's not, (due to the current symlink bug or so). A silent
success here won't make it clear whether "notmuch new" has actually done
anything or not.

-Carl

Re: [PATCH] notmuch-new: Remove the tiresome joke from the output.

[Marten Veldthuis]

On Fri, Nov 27, 2009 at 05:46:32AM -0800, Carl Worth wrote:
>> -    } else {
>> -	printf ("No new mail---and that's not much.\n");
>>      }
>
>Shouldn't we still print *something* here, though ("No new mail")?
>Imagine the new user trying to ensure "notmuch new" is working---and
>let's say it's not, (due to the current symlink bug or so). A silent
>success here won't make it clear whether "notmuch new" has actually done
>anything or not.

Yes, at first I thought I'd read the patch wrong... I think you definately 
want some output, just not the joke. Don't worry, it *was* funny the first 
time.

-- 
- Marten