From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0FCD3431FBC for ; Fri, 27 Nov 2009 06:19:04 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z0ZfU49WUzJl for ; Fri, 27 Nov 2009 06:19:03 -0800 (PST) Received: from out4.smtp.messagingengine.com (out4.smtp.messagingengine.com [66.111.4.28]) by olra.theworths.org (Postfix) with ESMTP id 6B88D431FAE for ; Fri, 27 Nov 2009 06:19:03 -0800 (PST) Received: from compute1.internal (compute1.internal [10.202.2.41]) by gateway1.messagingengine.com (Postfix) with ESMTP id 0EF16C159A for ; Fri, 27 Nov 2009 09:19:03 -0500 (EST) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 27 Nov 2009 09:19:03 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=date:from:to:subject:message-id:references:mime-version:content-type:in-reply-to; s=smtpout; bh=giWtWp4ZeA9PxM13Wn89F3dpspg=; b=unF5Cnr5/bBuZI+4nDC3sTZdT6EFkVB8CRuDsE4zG4yEkGIBchmMLFGtIxqIsMwHYaHQjeA8Kr/JeixDHhxGhgvx7ZRs+MFLoWasJlAhQDz0vvKDgrm4o9lcjNPV29AjnZWBFbwDEU5CT592my/s+1f7c85LcXCFluBDQTD07BE= X-Sasl-enc: 8Ophv8Z30l50VvDRKuojEmrAZt1uESDj+H4sASSizQr+ 1259331541 Received: from marten.rgoc.rug.nl (marten.rgoc.rug.nl [129.125.147.35]) by mail.messagingengine.com (Postfix) with ESMTPSA id A783A488539 for ; Fri, 27 Nov 2009 09:19:01 -0500 (EST) Received: by marten.rgoc.rug.nl (sSMTP sendmail emulation); Fri, 27 Nov 2009 15:18:50 +0100 Date: Fri, 27 Nov 2009 15:18:50 +0100 From: Marten Veldthuis To: notmuch@notmuchmail.org Message-ID: <20091127141850.GA1198@socpsy35> References: <1259091680-29598-1-git-send-email-chris@chris-wilson.co.uk> <878wdsqdvr.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <878wdsqdvr.fsf@yoom.home.cworth.org> User-Agent: Mutt/1.5.20 (2009-06-14) Subject: Re: [PATCH] notmuch-new: Remove the tiresome joke from the output. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2009 14:19:04 -0000 On Fri, Nov 27, 2009 at 05:46:32AM -0800, Carl Worth wrote: >> - } else { >> - printf ("No new mail---and that's not much.\n"); >> } > >Shouldn't we still print *something* here, though ("No new mail")? >Imagine the new user trying to ensure "notmuch new" is working---and >let's say it's not, (due to the current symlink bug or so). A silent >success here won't make it clear whether "notmuch new" has actually done >anything or not. Yes, at first I thought I'd read the patch wrong... I think you definately want some output, just not the joke. Don't worry, it *was* funny the first time. -- - Marten