From: Jan Janak <jan@ryngle.com>
To: Bart Trojanowski <bart@jukie.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/4] notmuch: Config option to specify tags to be applied by 'notmuch new'.
Date: Wed, 25 Nov 2009 22:50:08 +0100 [thread overview]
Message-ID: <20091125215008.GG25119@ryngle.com> (raw)
In-Reply-To: <20091125205639.GJ29312@jukie.net>
Hi Bart,
On 25-11 15:56, Bart Trojanowski wrote:
> Jan,
>
> I really want this feature to get in, so I am going to do my best to
> review your code :)
>
> Here are some more sticking points...
>
> > +char **
> > +notmuch_config_get_new_tags (notmuch_config_t *config, size_t *length);
>
> If you are not giving over control of the pointer to the caller please
> return const char * const *.
I followed Carl's style there, in particular the following function:
notmuch_config_get_user_other_email
I can, of course, change that. But maybe we should wait for Carl to see
which way he prefers.
> Similarly...
>
> > + char **new_tags;
>
> ... this should probably be const char **.
That's the same story. I followed user_other_email there.
> Next...
>
> > +char **
> > +notmuch_config_get_new_tags (notmuch_config_t *config, size_t *length)
>
> ... but ...
>
> > + unsigned int count, i;
> > +
> > + if ((tags = notmuch_config_get_new_tags (config, &count)) == NULL)
> > + return;
>
> size_t != unsigned int on all platforms. Please stick with one or the
> other. Note there are a few calls to fix here.
That's a good catch. I will fix that one. Thanks a lot for the review, I
really appreciate that!
-- Jan
next prev parent reply other threads:[~2009-11-25 21:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 22:10 [PATCH 0/4] Make tags applied by 'notmuch new' configurable Jan Janak
2009-11-24 22:10 ` [PATCH 1/4] notmuch-new: Remove tag_add_inbox_unread in favor of a generic solution Jan Janak
2009-11-24 22:10 ` [PATCH 2/4] notmuch: Config option to specify tags to be applied by 'notmuch new' Jan Janak
2009-11-24 22:10 ` [PATCH 3/4] notmuch-setup: Copy/create the new section with tags for 'notmuch-new' Jan Janak
2009-11-24 22:10 ` [PATCH 4/4] notmuch-new: New cmdline option --tag=<name> Jan Janak
2009-11-25 6:21 ` Karl Wiberg
2009-11-25 17:59 ` Jan Janak
2009-11-25 18:37 ` [PATCH] notmuch-new: Option to disable tags from the configuration file Jan Janak
2009-11-25 19:55 ` Bart Trojanowski
2009-11-25 21:25 ` Jan Janak
2009-11-25 20:56 ` [PATCH 2/4] notmuch: Config option to specify tags to be applied by 'notmuch new' Bart Trojanowski
2009-11-25 21:50 ` Jan Janak [this message]
2009-12-02 21:42 ` Carl Worth
2009-11-24 22:50 ` [PATCH 0/4] Make tags applied by 'notmuch new' configurable Brett Viren
2009-11-25 3:07 ` Bdale Garbee
2009-11-25 3:35 ` Bart Trojanowski
2009-11-25 23:30 ` [PATCH 1/5] notmuch-new: Remove tag_add_inbox_unread in favor of a generic solution Jan Janak
2009-11-25 23:30 ` [PATCH 2/5] notmuch: Config option to specify tags to be applied by 'notmuch new' Jan Janak
2009-11-25 23:30 ` [PATCH 3/5] notmuch-setup: Copy/create the new section with tags for 'notmuch-new' Jan Janak
2009-11-25 23:30 ` [PATCH 4/5] notmuch-new: New cmdline option --tag=<name> Jan Janak
2009-11-25 23:30 ` [PATCH 5/5] notmuch-new: Option to disable tags from the configuration file Jan Janak
2009-11-25 23:48 ` [PATCH 0/4] Make tags applied by 'notmuch new' configurable Jan Janak
2009-12-02 21:36 ` Carl Worth
2009-12-03 9:48 ` Marten Veldthuis
2009-12-04 6:17 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091125215008.GG25119@ryngle.com \
--to=jan@ryngle.com \
--cc=bart@jukie.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).