From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 912FF431FBF for ; Sun, 22 Nov 2009 10:33:44 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9T+Abdbhab0i for ; Sun, 22 Nov 2009 10:33:43 -0800 (PST) Received: from sirius.lasnet.de (sirius.lasnet.de [78.47.116.19]) by olra.theworths.org (Postfix) with ESMTP id 39D1C431FAE for ; Sun, 22 Nov 2009 10:33:43 -0800 (PST) Received: from p5b0353d3.dip.t-dialin.net ([91.3.83.211] helo=excalibur) by sirius.lasnet.de with esmtpsa (Cipher TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63 #1) id 1NCHFh-0000dR-It by authid with cram_md5; Sun, 22 Nov 2009 19:33:40 +0100 Received: from stefan by excalibur with local (Exim 4.69) (envelope-from ) id 1NCHFi-0002ot-2C; Sun, 22 Nov 2009 19:33:38 +0100 Date: Sun, 22 Nov 2009 19:33:38 +0100 From: Stefan Schmidt To: Keith Packard Message-ID: <20091122183338.GB5735@excalibur.local> References: <1258848661-4660-1-git-send-email-stefan@datenfreihafen.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: X-Mailer: Mutt http://www.mutt.org/ X-KeyID: 0xDDF51665 X-Website: http://www.datenfreihafen.org/ User-Agent: Mutt/1.5.20 (2009-06-14) Cc: notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] lib/message: Add function to get maildir flags. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Nov 2009 18:33:44 -0000 --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello. On Sat, 2009-11-21 at 16:28, Keith Packard wrote: > On Sun, 22 Nov 2009 01:11:00 +0100, Stefan Schmidt wrote: >=20 > > +const char * > > +notmuch_message_get_flags (notmuch_message_t *message) >=20 > This function should interpret the flags that it finds and return a > suitable set of notmuch tags. I'd suggest that 'unread' messages get > both 'unread' and 'inbox' tags, as Maildir doesn't distinguish between > 'don't show this to be by default again please' and 'I've read this > message'. It seems best to hide the maildir-specific details inside the > library instead of exposing them. Thanks for the review. On a second thought the interface was really a bit u= gly. :) I'm just back to my box and going through the outstanding mails shows me th= at Michiel Buddingh has a more complete patch on the convert-maildir-flags-into-tags issue which Carl has tagged for review. Will wait what comes out of it and if anything is left for me to. :) regards Stefan Schmidt --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: http://www.datenfreihafen.org/contact.html iEYEARECAAYFAksJhAIACgkQbNSsvd31FmWDDgCgswbE3BE2XeExPzBBJf86efDw aFwAoMc3vaBmTjB2kG5ORUmk1E/ICBXK =k8v5 -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--