From: Mike Hommey <mh+notmuch@glandium.org>
To: Carl Worth <cworth@cworth.org>
Cc: notmuch@notmuchmail.org
Subject: Re: Segfault with weird Message-ID
Date: Fri, 20 Nov 2009 22:05:56 +0100 [thread overview]
Message-ID: <20091120210556.GA25421@glandium.org> (raw)
In-Reply-To: <87y6m0lxym.fsf@yoom.home.cworth.org>
On Fri, Nov 20, 2009 at 09:53:37PM +0100, Carl Worth wrote:
> On Fri, 20 Nov 2009 14:26:25 +0100, Mike Hommey <mh+notmuch@glandium.org> wrote:
> > - for some reason, xapian doesn't want to add the document corresponding
> > to this old spam message: notmuch->xapian_db->add_document throws an
> > exception.
>
> I think things had just gone wrong long before then.
I *did* see it throwing an exception from there. The sad thing is that I
can't reproduce the problem anymore :-/
> > I can provide the spam if necessary, or can continue debugging the issue
> > with some guidance.
>
> Thanks for providing it. It turns out that the giant Message-Id value
> wasn't causing the problem. Instead the message was corrupt by having a
> stray new line at the third line. (So GMime is seeing only the first two
> lines of headers). We *used* to have working code to detect this kind of
> file as "not an email" but again, this broke when we changed
> notmuch_message_get_header to return "" instead of NULL for missing
> headers.
Interestingly, when I first traced on what message the crash was
happening, I did see notmuch having the message-id in the message_id
variable.
FWIW, that was using c05c3f1.
I'll see if I can reproduce my segfault again when starting from scratch
again, and will also give a try to your patches.
Cheers,
Mike
next prev parent reply other threads:[~2009-11-20 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 13:26 Segfault with weird Message-ID Mike Hommey
2009-11-20 17:04 ` Carl Worth
2009-11-20 20:53 ` Carl Worth
2009-11-20 21:05 ` Mike Hommey [this message]
2009-11-21 22:26 ` Mike Hommey
2009-11-22 3:12 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091120210556.GA25421@glandium.org \
--to=mh+notmuch@glandium.org \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).