From: racin@free.fr
To: Carl Worth <cworth@cworth.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] Support for deletion (patch included)
Date: Sat, 27 Feb 2010 11:34:27 +0100 (CET) [thread overview]
Message-ID: <1673492941.5760781267266866949.JavaMail.root@zimbra1-e1.priv.proxad.net> (raw)
In-Reply-To: <1427711643.5760731267266834921.JavaMail.root@zimbra1-e1.priv.proxad.net>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
Here they are; as I don't know how to include them in the body, I put the patches as attachments. I hope this
will be convienient enough for you.
Matthieu
----- racin@free.fr a écrit :
> Carl: The patch in the mail has problems; apparently I have to
> manually add scissorlines to the mail for it
> to be processed by git-am. I thought this was automatically added. (I
> hate the git UI -- nothing is consistent,
> concepts have different names, the definition of scissor lines is as
> precise as "A line that mainly consists of scissors (either ">8" or
> "8<") and perforation (dash "-") --, but I guess we can get used to it
> after a while...)
>
> I'll send you a proper patch as soon as I can. Meanwhile, I'm sure you
> have comments on this updated patch!
>
> Matthieu
>
[-- Attachment #2: 0002-Add-support-for-deletion-in-the-emacs-interface.patch --]
[-- Type: text/x-diff, Size: 5933 bytes --]
From 0073152e3fa7dd11d88de28e87eec7762cdbbbeb Mon Sep 17 00:00:00 2001
From: Matthieu Lemerre <racin@free.fr>
Date: Thu, 25 Feb 2010 00:25:51 +0100
Subject: [PATCH 2/2] Add support for deletion in the emacs interface
Add "d" keybinding in notmuch-show and notmuch-summary to delete the current
thread. Adds "D" keybinding to delete the current message in notmuch-show.
Adds a "deleted" folder. Omit deleted items from searchs if no prefix arg.
Adds history management to make searching deleted items more convenient.
---
notmuch.el | 56 +++++++++++++++++++++++++++++++++++++++++++++++++-------
1 files changed, 49 insertions(+), 7 deletions(-)
diff --git a/notmuch.el b/notmuch.el
index 5d7342a..0285573 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -92,6 +92,8 @@
(define-key map "x" 'notmuch-show-archive-thread-then-exit)
(define-key map "A" 'notmuch-show-mark-read-then-archive-thread)
(define-key map "a" 'notmuch-show-archive-thread)
+ (define-key map "d" 'notmuch-show-delete-thread)
+ (define-key map "D" 'notmuch-show-delete-message)
(define-key map "p" 'notmuch-show-previous-message)
(define-key map "N" 'notmuch-show-mark-read-then-next-open-message)
(define-key map "n" 'notmuch-show-next-message)
@@ -380,6 +382,23 @@ buffer."
(notmuch-show-archive-thread)
(kill-this-buffer))
+(defun notmuch-show-delete-message ()
+ "Delete current message (sets its deleted tag)."
+ (interactive)
+ (notmuch-show-add-tag "deleted"))
+
+(defun notmuch-show-delete-thread()
+ "Delete each message in thread."
+ (interactive)
+ (notmuch-show-forall-in-thread
+ (notmuch-show-delete-message)))
+
+(defun notmuch-show-delete-thread-and-exit()
+ "Delete each message in thread, then exit back to search results."
+ (interactive)
+ (notmuch-show-delete-thread)
+ (kill-this-buffer))
+
(defun notmuch-show-mark-read-then-archive-then-exit ()
"Remove unread tags from thread, then archive and exit to search results."
(interactive)
@@ -1227,6 +1246,7 @@ matching this search term are shown if non-nil. "
(define-key map [mouse-1] 'notmuch-search-show-thread)
(define-key map "*" 'notmuch-search-operate-all)
(define-key map "a" 'notmuch-search-archive-thread)
+ (define-key map "d" 'notmuch-search-delete-thread)
(define-key map "-" 'notmuch-search-remove-tag)
(define-key map "+" 'notmuch-search-add-tag)
(define-key map (kbd "RET") 'notmuch-search-show-thread)
@@ -1235,6 +1255,7 @@ matching this search term are shown if non-nil. "
(fset 'notmuch-search-mode-map notmuch-search-mode-map)
(defvar notmuch-search-query-string)
+(defvar notmuch-search-history nil)
(defvar notmuch-search-oldest-first t
"Show the oldest mail first in the search-mode")
@@ -1446,6 +1467,13 @@ This function advances the next thread when finished."
(notmuch-search-remove-tag "inbox")
(forward-line))
+(defun notmuch-search-delete-thread ()
+ "Mark the currently selected thread as deleted (set its \"deleted\" tag).
+This function advances the next thread when finished."
+ (interactive)
+ (notmuch-search-add-tag "deleted")
+ (forward-line))
+
(defun notmuch-search-process-sentinel (proc msg)
"Add a message to let user know when \"notmuch search\" exits"
(let ((buffer (process-buffer proc))
@@ -1520,10 +1548,22 @@ characters as well as `_.+-'.
(append action-split (list notmuch-search-query-string) nil))))
;;;###autoload
-(defun notmuch-search (query &optional oldest-first)
- "Run \"notmuch search\" with the given query string and display results."
- (interactive "sNotmuch search: ")
- (let ((buffer (get-buffer-create (concat "*notmuch-search-" query "*"))))
+(defun notmuch-search (query &optional oldest-first include-deleted)
+ "Run \"notmuch search\" with the given query string and display results.
+
+With prefix argument, include deleted items.
+"
+ (interactive (let* ((prefix current-prefix-arg)
+ (query (if prefix
+ (read-string "Notmuch search (including deleted): "
+ notmuch-search-query-string
+ 'notmuch-search-history)
+ (read-string "Notmuch search: " nil
+ 'notmuch-search-history))))
+ (list query nil prefix)))
+ (let ((real-query (if include-deleted query
+ (concat "not tag:deleted and (" query ")")))
+ (buffer (get-buffer-create (concat "*notmuch-search-" query "*"))))
(switch-to-buffer buffer)
(notmuch-search-mode)
(set 'notmuch-search-query-string query)
@@ -1539,7 +1579,7 @@ characters as well as `_.+-'.
(let ((proc (start-process-shell-command
"notmuch-search" buffer notmuch-command "search"
(if oldest-first "--sort=oldest-first" "--sort=newest-first")
- (shell-quote-argument query))))
+ (shell-quote-argument real-query))))
(set-process-sentinel proc 'notmuch-search-process-sentinel)
(set-process-filter proc 'notmuch-search-process-filter))))
(run-hooks 'notmuch-search-hook)))
@@ -1587,7 +1627,7 @@ search."
Runs a new search matching only messages that match both the
current search results AND the additional query string provided."
- (interactive "sFilter search: ")
+ (interactive "sFilter search:")
(let ((grouped-query (if (string-match-p notmuch-search-disjunctive-regexp query) (concat "( " query " )") query)))
(notmuch-search (concat notmuch-search-query-string " and " grouped-query) notmuch-search-oldest-first)))
@@ -1630,7 +1670,9 @@ current search results AND that are tagged with the given tag."
(fset 'notmuch-folder-mode-map notmuch-folder-mode-map)
-(defcustom notmuch-folders (quote (("inbox" . "tag:inbox") ("unread" . "tag:unread")))
+(defcustom notmuch-folders (quote (("inbox" . "tag:inbox")
+ ("unread" . "tag:unread")
+ ("deleted" . "tag:deleted")))
"List of searches for the notmuch folder view"
:type '(alist :key-type (string) :value-type (string))
:group 'notmuch)
--
1.6.5
[-- Attachment #3: 0001-Add-and-use-notmuch-show-forall-in-thread-macro.patch --]
[-- Type: text/x-diff, Size: 1580 bytes --]
From bdee9558d93bffb97c80632f522288e059deb7c2 Mon Sep 17 00:00:00 2001
From: Matthieu Lemerre <racin@free.fr>
Date: Thu, 25 Feb 2010 00:24:24 +0100
Subject: [PATCH 1/2] Add and use notmuch-show-forall-in-thread macro
This macro allows to apply a message-related command to every message
in a thread.
---
notmuch.el | 17 +++++++++++------
1 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/notmuch.el b/notmuch.el
index 6482170..5d7342a 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -321,17 +321,22 @@ pseudoheader summary"
(cons (notmuch-show-get-message-id) nil)))
(notmuch-show-set-tags (sort (set-difference tags toremove :test 'string=) 'string<))))))
-(defun notmuch-show-archive-thread-maybe-mark-read (markread)
- (save-excursion
+(defmacro notmuch-show-forall-in-thread (&rest body)
+ "Executes BODY with point in all messages of the current thread."
+ `(save-excursion
(goto-char (point-min))
(while (not (eobp))
- (if markread
- (notmuch-show-remove-tag "unread" "inbox")
- (notmuch-show-remove-tag "inbox"))
+ ,@body
(if (not (eobp))
(forward-char))
(if (not (re-search-forward notmuch-show-message-begin-regexp nil t))
- (goto-char (point-max)))))
+ (goto-char (point-max))))))
+
+(defun notmuch-show-archive-thread-maybe-mark-read (markread)
+ (notmuch-show-forall-in-thread
+ (if markread
+ (notmuch-show-remove-tag "unread" "inbox")
+ (notmuch-show-remove-tag "inbox")))
(let ((parent-buffer notmuch-show-parent-buffer))
(kill-this-buffer)
(if parent-buffer
--
1.6.5
next parent reply other threads:[~2010-02-27 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1427711643.5760731267266834921.JavaMail.root@zimbra1-e1.priv.proxad.net>
2010-02-27 10:34 ` racin [this message]
[not found] <829811857.5353531267112884804.JavaMail.root@zimbra1-e1.priv.proxad.net>
2010-02-25 15:51 ` [PATCH] Support for deletion (patch included) racin
2009-12-13 11:54 Matthieu Lemerre
2010-02-24 18:49 ` Carl Worth
2010-02-25 0:00 ` racin
2010-02-25 10:49 ` Sebastian Spaeth
2010-03-01 9:09 ` Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1673492941.5760781267266866949.JavaMail.root@zimbra1-e1.priv.proxad.net \
--to=racin@free.fr \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).