From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QIj3CA63B2J0gwEAgWs5BA (envelope-from ) for ; Sat, 12 Feb 2022 14:33:02 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GAJYBg63B2LKaQEA9RJhRA (envelope-from ) for ; Sat, 12 Feb 2022 14:33:02 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9EF6323C9F for ; Sat, 12 Feb 2022 14:33:01 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 441E85F702; Sat, 12 Feb 2022 13:32:59 +0000 (UTC) Received: from mailproxy01.manitu.net (mailproxy01.manitu.net [217.11.48.65]) by mail.notmuchmail.org (Postfix) with ESMTPS id 228725F6C3 for ; Sat, 12 Feb 2022 13:32:57 +0000 (UTC) Received: from localhost (nb-ana002.math.uni-hannover.de [130.75.46.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: michael@grubix.eu) by mailproxy01.manitu.net (Postfix) with ESMTPSA id 2CFF81260088; Sat, 12 Feb 2022 14:32:56 +0100 (CET) MIME-Version: 1.0 In-Reply-To: <87k0e1x87f.fsf@tethera.net> References: <164458773197.3086.16103597141743611268.git@grubix.eu> <87k0e1x87f.fsf@tethera.net> Subject: Re: Test suite timing issues? From: Michael J Gruber To: David Bremner Message-ID: <164467277576.6467.13919733764427871872.git@grubix.eu> Date: Sat, 12 Feb 2022 14:32:55 +0100 User-Agent: alot/0.10 Message-ID-Hash: S2UM3W45236VJJUKS5ZSHG2ERTSRBPC5 X-Message-ID-Hash: S2UM3W45236VJJUKS5ZSHG2ERTSRBPC5 X-MailFrom: michael@grubix.eu X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644672781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=I2UbuxX8fjVjx9GQZU8K+/FotN6MVvqrGj+jQ4QVOyw=; b=DvvFzHlrHXZh55y9uWEQmUfZOoGYDQPxqQ2sLSgOv67aZUyfPDrw7xs4WihPPy14ZdOuEv ACUKWBSdXyW4PxqbFwxMGr42zfdV59Mgzz1FWttrsAp6NIMFJCF8I1LjaW/Bmjjdjog3ID Hnx2ShBDjR2+hAy8Z/jaGYlU97p3HY2hEocnK0patmgPYtWcqGLvRcrN46BrUT6f6ouRDO Ynd2Rwb5Zf6CDSJZPRRiHQwFxhKVrg0cLaA2HTITAWKpIHQNzt3IbHo8Rog3c0V6E/1NhB nr0FkcBhSStrb49goc/a1bqctY71dCddhD1dzODTFyV5ML9UZcVMQEf5riDhkQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644672781; a=rsa-sha256; cv=none; b=D3V/aOpy/KdU64g1Xy3t26WSPhSNv5/1TvvqQtm0Xs+yVBHaybcHm4i8iu9nC+7WHEYn/Q QSax1n9M4P6ekSitSk5y6ZruBzIBBmz15qDmjIlOJskT+Ju+mfE8NnkSj3eJL5yR0LEkHk jktxqu483n2faLivqY5yRhzFmgaqUemkS0F7nfD5xLEPTBejWfBONf5Y4aWc9ar6qRqTNG JLlwWRDE2wcTLryNEdnk4V/QYQKeIRUH4qIPQjTZpeL9O6RvQeTRHSFGVvSTFv1Xo8s3Pt pkESS7c8csweRLFuVYmPVn9zzDftoUD2LXlRZ3pFrWG3cUFzrSEN9BvKmjPIDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.54 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 9EF6323C9F X-Spam-Score: -0.54 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4p/ivp5vwt3I David Bremner venit, vidit, dixit 2022-02-12 01:03:00: > Michael J Gruber writes: > > > Hi there, > > > > I'm trying to package notmuch for Redhat's enterprise linux and clones > > (EPEL, extra packages for enterprise linux). > > > > This looks mostly fine, including the tests, except for intermittent > > failures on epel-8-s390x. They look like the below, or in tests > > following those, and apparantly all have to do with "db not synced yet" > > or such, so that a message one subtest creates only shows up in the db > > for the next subtest. > > > > I've also had completely fine test runs on epel-8-s390x, but I'm > > starting to wonder whether I've just been lucky so far on other > > platforms ... Could it be possible that generate_message(), even though > > adding the message, still returns false and therefore add_message() does > > not call "notmuch new"? One might want to drop the "&&" there in > > test-lib-common, I dunno. This shouldn't be "intermittent". > > It's hard to see what can go wrong (maybe perl doesn't work?), but > failing to generate a message should be a fatal error. Maybe try > something like > Well, as you can see in both reports, the pattern is as follows: The first subttest sees 1 less message than expected. The second sees 1 more message than expected. So in summary, they are generated but "notmuch new" is not run or does not pick them up. Though it's a Heisenbug on a specific arch, I'll try your suggestion and hammer our infra with it ... > diff --git a/test/test-lib-common.sh b/test/test-lib-common.sh > index ebbf4cdf..076777ca 100644 > --- a/test/test-lib-common.sh > +++ b/test/test-lib-common.sh > @@ -225,7 +225,7 @@ EOF > # All of the arguments and return values supported by generate_message > # are also supported here, so see that function for details. > add_message () { > - generate_message "$@" && > + generate_message "$@" || error "failed to generate message" > notmuch new > /dev/null > } > > > to see if you get more information