From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IFteK0blBGKJRwEAgWs5BA (envelope-from ) for ; Thu, 10 Feb 2022 11:13:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ABkJJEblBGLhMAAAG6o9tA (envelope-from ) for ; Thu, 10 Feb 2022 11:13:26 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5BBCA19F1C for ; Thu, 10 Feb 2022 11:13:26 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 20CE75F721; Thu, 10 Feb 2022 10:13:24 +0000 (UTC) Received: from mailproxy07.manitu.net (mailproxy07.manitu.net [217.11.48.71]) by mail.notmuchmail.org (Postfix) with ESMTPS id 7CA145F71F for ; Thu, 10 Feb 2022 10:13:22 +0000 (UTC) Received: from localhost (200116b8605b9100a390552ff161dcf3.dip.versatel-1u1.de [IPv6:2001:16b8:605b:9100:a390:552f:f161:dcf3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: michael@grubix.eu) by mailproxy07.manitu.net (Postfix) with ESMTPSA id 36630C8A83; Thu, 10 Feb 2022 11:13:24 +0100 (CET) MIME-Version: 1.0 In-Reply-To: References: <0ccbe5428179bdf550d13ac715db70e78fc9a7c4.1644406756.git.git@grubix.eu> Subject: Re: [PATCH 4/4] test: set up the outcount file for T380.1 From: Michael J Gruber To: Tomi Ollila , notmuch@notmuchmail.org Message-ID: <164448800145.6325.10970593977371856162.git@grubix.eu> Date: Thu, 10 Feb 2022 11:13:21 +0100 User-Agent: alot/0.10 Message-ID-Hash: RAEZSSOE5FN7FETE5YLILY7SEKO5UKPR X-Message-ID-Hash: RAEZSSOE5FN7FETE5YLILY7SEKO5UKPR X-MailFrom: michael@grubix.eu X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644488006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=QB/rnlch0OY3GiSbmpd+jg/e7HRvB2sCUFAtmA/fOmo=; b=jjMFcvI3mswR6ITX2OwL3TQCvC3S82pLwQs6JdG8cOAtsJ+Ia6u9huL8XJuji3uH8Aaw01 kjutaoRLQIHZBbs0dJA8TNgsZ5ESemd4hO7OzoFrfEwA8fHPZWI0rifpm5PM/FPwLmLqk3 3dA2mTUoBTSKLLGcG8hz2Wo0ttP+/q4bJ9F1m4fQMG2JG4XLQLLjrWfbz/6HquTJVythCO Y84GxXFkdSgvxZgBPJGFqhp+/cVNtFHqSXYIHPwEda8+FRz54ylDc3WeG+zQFQQPc18sPw 2xBH9ByTZk9H+DGNL2SksccYbtHDOeClQdxotpim3/iV64gz+5CUbZLCIUezbA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644488006; a=rsa-sha256; cv=none; b=d2bdfZEFICUlvsE+9ytCoomYyY0vK76LBKxor32uqFgn9GU3/3f1pARBSZml5Oc4Ar0coI 4sFsmLf7OwSLnjkkuV4F4SzRoa65tgvo5KhyLJLZ91t+ncnwy3sWK6/v0KtZbUqkBaM5AW Vs6qwWgyu4WaI18lY54WXuq61gzPwoydmRjZcfMs7eM7PzHQcgLXXYis6QSUoMzUZ33Yts 4qOalaqCztrw3JZZ1swwv179MRAr1ecHD1QwEQvVnPfdVCHHwAyeFuDMYNkCfWXde8YOQ5 dRNWS74D4MW5dzqb5PitkdwwbP487n3t9oVSjvdcgiQfNa6q8vvR4nzeTP5oMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 5BBCA19F1C X-Spam-Score: -2.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: xxELqJwrVeI1 Tomi Ollila venit, vidit, dixit 2022-02-09 21:50:35: > On Wed, Feb 09 2022, Michael J. Gruber wrote: > > > If gdb is present but for some reason `atomicity.py` fails to write to > > the output file then the test fails with some ugly bash errors in the > > wrong places (because the outcount variable is empty). > > > > Therefore, set up the outcount file with `0` to get the test script to > > rund and the test to fail fpr a clearer reason. > > > > Background: We noticed this with arch armhfp emulated on x86_64 in > > Fedora's COPR test build environment. > > > > Signed-off-by: Michael J Gruber > > --- > > test/T380-atomicity.sh | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh > > index 49df5c38..caac28a3 100755 > > --- a/test/T380-atomicity.sh > > +++ b/test/T380-atomicity.sh > > @@ -64,6 +64,7 @@ if test_require_external_prereq gdb; then > > # -tty /dev/null works around a conflict between the 'timeout' wrapper > > # and gdb's attempt to control the TTY. > > export MAIL_DIR > > + echo -n 0 > outcount > > printf 0 > outcount (is my suggestion) Would by mine, too :) Again, this is not the style of T380 which uses echo exclusively so far. I do think that printf is more stable across different systems and shells, so a mass replace would be in order (but requires careful nl checking). Overally in the test suite, [f]printf wins by 8:3 roughly. > > > ${TEST_GDB} -tty /dev/null -batch -x $NOTMUCH_SRCDIR/test/atomicity.py notmuch 1>gdb.out 2>&1 > > > > # Get the final, golden output > > -- > > 2.35.1.306.ga00bde9711