From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6MjyKTvlBGIzSAEAgWs5BA (envelope-from ) for ; Thu, 10 Feb 2022 11:13:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qPanIjvlBGJWKwAAG6o9tA (envelope-from ) for ; Thu, 10 Feb 2022 11:13:15 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5DBEE1A015 for ; Thu, 10 Feb 2022 11:13:15 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 628695F718; Thu, 10 Feb 2022 10:13:12 +0000 (UTC) X-Greylist: delayed 445 seconds by postgrey-1.36 at yantan; Thu, 10 Feb 2022 10:13:10 UTC Received: from mailproxy05.manitu.net (mailproxy05.manitu.net [217.11.48.69]) by mail.notmuchmail.org (Postfix) with ESMTPS id 3CBEB5F704 for ; Thu, 10 Feb 2022 10:13:10 +0000 (UTC) Received: from localhost (200116b8605b9100a390552ff161dcf3.dip.versatel-1u1.de [IPv6:2001:16b8:605b:9100:a390:552f:f161:dcf3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: michael@grubix.eu) by mailproxy05.manitu.net (Postfix) with ESMTPSA id D69341B60662; Thu, 10 Feb 2022 11:05:43 +0100 (CET) MIME-Version: 1.0 In-Reply-To: References: <51ecae6ac67b360410790ce7ad208162ecc7d517.1644406756.git.git@grubix.eu> Subject: Re: [PATCH 1/4] test: correct comparison order in T380 From: Michael J Gruber To: Tomi Ollila , notmuch@notmuchmail.org Message-ID: <164448754380.6325.4951812838631850484.git@grubix.eu> Date: Thu, 10 Feb 2022 11:05:43 +0100 User-Agent: alot/0.10 Message-ID-Hash: 5Z4H22IYYKRRF2VIB4SGSVWJSDFM4UTE X-Message-ID-Hash: 5Z4H22IYYKRRF2VIB4SGSVWJSDFM4UTE X-MailFrom: michael@grubix.eu X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644487995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=1XtCfTNjHpJaMLcPpsmdYx2vcJHjfkMDr2eN5rwj58Y=; b=Wt5K2lSzcIuPOg3O3/b+IVwU5GerO1ImwUA1/hWPbIah58SPCGU3pDDa3Q4ONiyYw4eKfv Z58mK9NnnjVHQqVgYzpIl19lJ5tPlejWE+DFHWSm51HyoeSOfpDoqKckRhBkXwelkz5xjO u7gDvwtGKPQ6uzKn4OCGi6B3DRTnUCcXZ7q/jAXFnyygw0VvSc9c6F+WGhng0fWg1A/Rcp 22RPZJ60XyEloHatuoikBkuyQ4VkPBc7PaZy1TBtp/4ydMLwBLmeFBG4t7OUpwWdxICVCK aQjHnpipKeXtsNQds2w1hXxVyhxOls5+mez7P6NcdBnKu2TI27I2PJ4HfcsDhA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644487995; a=rsa-sha256; cv=none; b=d63yLTq/N6YOTMW8WKTAlenssGnl9GaQO+IJoaV4CgDtWmLcYDxt/C4luCmqriCGM3rTLZ 2YyDcwGFVSCXGOKOpZJU2D3ujW6E+K8zKJ39twbI1IvTe9pHPSK1zFxliI+j1SwJOK0gMX nQFNzXZQ+GcYvsNLkUmR/ewiQTrRIho0uP6BULtxQvJXZ+SBKsYt5PVN6jjjAtsnF9Uwy+ AucOt6BKNo91YPicgfM6/ep57erOApAXcRVAHkoYbuyzk4wVP+Vt14XcaqZv+0WpeUMD8C 7V+Cu1pqSy54w5NwP0M+VyBk2vsBzLOiq+KZZenYMOSAbyBO7UH9bCqkR/NsiA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.53 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 5DBEE1A015 X-Spam-Score: -1.53 X-Migadu-Scanner: scn1.migadu.com X-TUID: pO6+L/iZpEIs Tomi Ollila venit, vidit, dixit 2022-02-09 21:47:46: > On Wed, Feb 09 2022, Michael J. Gruber wrote: > > > Specifying test comparisons as "expected actual" gives a better readable > > diff since the "-" indicates missing, "+" additional items compared to > > the expectations. > > > > Signed-off-by: Michael J Gruber > > --- > > test/T380-atomicity.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh > > index afe49d93..a6f1e037 100755 > > --- a/test/T380-atomicity.sh > > +++ b/test/T380-atomicity.sh > > @@ -93,7 +93,7 @@ if test_require_external_prereq gdb; then > > fi > > > > test_begin_subtest '"notmuch new" is idempotent under arbitrary aborts' > > -test_expect_equal_file searchall expectall > > +test_expect_equal_file expectall searchall > > Good in princible, but if things are like decade ago, we still have > hundreds of these in wrong order -- if so, all should be changed for > consistency. If I am wrong and all / many of those are already changed, > then this is OK. I haven't checked, but the order add to the confusion created by "detected >10 abort points" which is why I changed it here, and in order to (mis-)use these files in the following commits. > > > > test_begin_subtest "detected $outcount>10 abort points" > > test_expect_success "test $outcount -gt 10" > > -- > > 2.35.1.306.ga00bde9711