From: Michael J Gruber <git@grubix.eu>
To: Alexander Adolf <alexander.adolf@condition-alpha.com>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] lib/notmuch_database_reopen: reload some database metada
Date: Tue, 11 May 2021 22:17:29 +0200 [thread overview]
Message-ID: <162076424929.3234.3999254277296434834.git@grubix.eu> (raw)
In-Reply-To: <87k0o5go2k.fsf@tethera.net>
David Bremner venit, vidit, dixit 2021-05-11 19:47:15:
> David Bremner <david@tethera.net> writes:
>
> > In some uses of reopen, new documents and threads maybe have been
> > added, and e.g. compaction may have changed the uuid.
>
> It's quite possible there is more cached data that should be discarded,
> but I'll have to think about that a bit more.
>
> d
Haven't tried your patch yet, but worked on a test which even produces
notmuch: lib/database.cc:1415: unsigned int
_notmuch_database_generate_doc_id(notmuch_database_t*): Assertion
`notmuch->last_doc_id >= notmuch->xapian_db->get_lastdocid ()' failed.
by calling notmuch insert --no-hooks inside the pre-new hook of notmuch
new ... (T400). I have to test with nm 0.31 and nm 0.32+plus patch
before I send this out.
Michael
next prev parent reply other threads:[~2021-05-11 20:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 7:51 Possible threading issues in nm 0.32 Michael J Gruber
2021-05-05 12:29 ` David Bremner
2021-05-08 15:45 ` Michael J Gruber
2021-05-11 14:04 ` Alexander Adolf
2021-05-11 14:32 ` Alexander Adolf
2021-05-11 15:41 ` Michael J Gruber
2021-05-11 16:56 ` Michael J Gruber
2021-05-11 17:39 ` David Bremner
2021-05-11 17:42 ` [PATCH] lib/notmuch_database_reopen: reload some database metada David Bremner
2021-05-11 17:47 ` David Bremner
2021-05-11 20:17 ` Michael J Gruber [this message]
2021-05-11 20:48 ` [PATCH] test: change database from within pre-new hook Michael J Gruber
2021-05-11 22:34 ` David Bremner
2021-05-12 7:23 ` Michael J Gruber
2021-05-12 11:47 ` David Bremner
2021-05-12 12:07 ` [PATCH] lib/notmuch_database_reopen: reload some database metada David Bremner
2021-05-12 13:30 ` Michael J Gruber
2021-05-16 11:11 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162076424929.3234.3999254277296434834.git@grubix.eu \
--to=git@grubix.eu \
--cc=alexander.adolf@condition-alpha.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).