From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AHDJDHCYJmBYSwAA0tVLHw (envelope-from ) for ; Fri, 12 Feb 2021 15:02:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OIOCCHCYJmBVCgAAB5/wlQ (envelope-from ) for ; Fri, 12 Feb 2021 15:02:08 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 87ED422916 for ; Fri, 12 Feb 2021 16:02:07 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 030751FF5B; Fri, 12 Feb 2021 10:01:59 -0500 (EST) Received: from mailproxy02.manitu.net (mailproxy02.manitu.net [217.11.48.66]) by mail.notmuchmail.org (Postfix) with ESMTPS id D7C321FE96 for ; Fri, 12 Feb 2021 10:01:55 -0500 (EST) Received: from localhost (200116b8608f60001c8a630219716c51.dip.versatel-1u1.de [IPv6:2001:16b8:608f:6000:1c8a:6302:1971:6c51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: michael@grubix.eu) by mailproxy02.manitu.net (Postfix) with ESMTPSA id EF276C15A3; Fri, 12 Feb 2021 16:01:40 +0100 (CET) MIME-Version: 1.0 In-Reply-To: <8735y1wiiu.fsf@tethera.net> References: <8735y1wiiu.fsf@tethera.net> Subject: Re: [PATCH] fix FTBFS with glib From: Michael J Gruber To: David Bremner , notmuch@notmuchmail.org Message-ID: <161314209981.18603.3506522745924633538.git@grubix.eu> Date: Fri, 12 Feb 2021 16:01:39 +0100 User-Agent: alot/0.9.1 Message-ID-Hash: 7ZSLL6FN5EIMDVZ5Z7U7SLKRU35VIMSN X-Message-ID-Hash: 7ZSLL6FN5EIMDVZ5Z7U7SLKRU35VIMSN X-MailFrom: michael@grubix.eu X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.07 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 87ED422916 X-Spam-Score: -1.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: sLTP549UPWpJ David Bremner venit, vidit, dixit 2021-02-12 13:57:29: > Michael J Gruber writes: > > > With newer glib, notmuch FTBFS because of C linkage error. This is due > > to a misplaced include (inside an extern "C") which was always there > > but exposed only recently through this change in glib: > > > > https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715 > > > > Move to the include to the outside of the extern block. > > Thanks for the patch. I have some questions / comments. > > 1) What version of glib are we talking about? Is it released yet? This showed up due to massive FTBFS on Fedora 34 (not released yet, but branched for release). glib 2.67.3 has the pertaining commit 51003d40. > 2) The reason this works is that gmime-extra.h has its own extern > "C". If respinning the patch, it might be worth commenting on that. Yes. If you don't distinguish betwenn h/hpp then that is the way to go. > 3) I observed that just deleting #include "gmime-extra.h" from > notmuch-private.h works fine, presumably because it is included where it > is actually needed. In some sense this seems like a nicer solution. What > do you think? Interesting. I assumed it's there for a reason. You introduced it in cbb2d560 ("lib/cli: replace use of g_mime_message_get_sender", 2017-05-05) so I guess you're the best person to ask whether it's till needed :) Removing an unnecessary include would be the best solution, of course. Cheers Michael