unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Johannes Larsen <mail@johslarsen.net>
To: notmuch@notmuchmail.org
Subject: python notmuch2 bindings exclude_tags not added correctly to query
Date: Wed, 23 Dec 2020 02:34:22 +0100	[thread overview]
Message-ID: <160868726210.3559542.13236319044064062818@hue.johslarsen.net> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 611 bytes --]

A typo in Database._create_query loses the exclude_tag names during the
string to utf-8 conversion.


The problem is fixed by this patch applied to current master (ced341e8):

diff --git i/bindings/python-cffi/notmuch2/_database.py w/bindings/python-cffi/notmuch2/_database.py
index 5ab0f20a..868f4408 100644
--- i/bindings/python-cffi/notmuch2/_database.py
+++ w/bindings/python-cffi/notmuch2/_database.py
@@ -581 +581 @@ class Database(base.NotmuchObject):
-                    tag = str.encode('utf-8')
+                    tag = tag.encode('utf-8')

-- 
johs (Johannes Larsen), (+47) 41435451

[-- Attachment #1.2: signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEpTer3kqGU3pr882G07zxebJvqyYFAl/inp0ACgkQ07zxebJv
qybIKQ//doa6TOk3jEfQ6UVO4potklF9klyPr0d9C/JwB7H/i4lCXosvdN/QK12P
IxyQUbje0LM4Y8ccZaEfd4fdq+HtY4jb4+8Fodpmmt9T6l3iGXels42lsP1GlYYo
lwG3O7lWPjjxyLf6kLVR+Tg2NMs62OBHJBwU/YotlZAn4aAldZhOjXvjpoEb1wx8
DGUGQiJm3iwQWbl+sPN9rRmGGHF53R3tsqpe8ffRUT/GUsbCoD//W/sHxKWu6W0l
jTW9kl/0rTg26mvuQZkD183ttIWD6iFAQzS50eb0wRmKg111I9ymF57d41SJ8pDG
8uYbmQ/wFrR84cuIZoMKGJozAUzLzaHKnh2HrNpd2sV0KHGus3CFfVyo38IxUewV
+wlBJJiZWY1yQ/2yzH8GzwFX2GSfcZTjERnq3mMtl80uVap6ukpYvJ8L2U8NnZK1
0RNLbF6aT7wgrNJdZTekHhysX/6VVUzmvIyx3MRcfvtMivsApxktQ+EkFCC1Ryy3
G7j1/wxEQRCCC8uKdjpgetXTm0GvruuCJTaWJaB8wKfEc7r7hKtP4U7F45NModeX
5+l6+N/JT57Twd6b1gmScYbnnNMMMLWp4sCa+1DARGWAXmXj9n3TYf9fgw5pkbb1
Jexuk/3egiJEZuxOwfoJh/C9rsBbWyWYAiNdKHjEsmoMY8qI7QY=
=OhfP
-----END PGP SIGNATURE-----

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2020-12-23  1:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23  1:34 Johannes Larsen [this message]
2020-12-24 16:08 ` python notmuch2 bindings exclude_tags not added correctly to query Floris Bruynooghe
2020-12-25 18:36 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160868726210.3559542.13236319044064062818@hue.johslarsen.net \
    --to=mail@johslarsen.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).