Re: [PATCH] python-cffi: read version from notmuch version file

[Frank LENORMAND <lenormf.ml@gmail.com>]

On Tue Jun 23 00:45:01 2020, Floris Bruynooghe wrote:
> On Fri 19 Jun 2020 at 15:26 +0300, Frank LENORMAND wrote:
> > It seems that this strategy doesn't work well when the user runs
> > `pip install .` in the `bindings/python-cffi` directory.
> >
> > Apparently all the files are copied to a temporary directory first:
> >
> > https://travis-ci.com/github/pazz/alot/jobs/351377760#L708-L710
> >
> > It doesn't happen with the original bindings, probably because the version
> > number is stored in `bindings/python/notmuch/version.py`, which is also
> > copied when `pip` runs.
> 
> Ouch, I only tested pip install -e, which does work.  But indeed a plain
> pip install no longer works which is pretty bad.
> 
> I guess we could either revert this and do the same sed hackery as the
> other bindings, or copy the version file into bindings/python-cffi and
> have it loaded in the same way as now.  It would still have to be kept
> in sync there sadly.

Actually, instead of having the version of the bindings follow that of the
main repository, why not have a separate one, but based on the latter?

For example, 0.30.1, with the first two numbers coming from the main
repository, and the last one acting as major for the bindings.

0.29.3 → 0.29.1
0.30-rc2 → 0.30.1-rc2
etc.

That way, users can still detect changes to the bindings that don't require
them to re-install the entire repository. You can also differentiate two
iterations of the bindings that work with the same NotMuch install.

You don't have to do any `sed` magic, but you will have to manually maintain
the version number in the bindings' directories.

Regards,
-- 
Frank LENORMAND