From: Dylan Baker <dylan@pnwbakers.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] python: deprecated add_message calls index_file correctly and returns result
Date: Tue, 12 Sep 2017 15:24:58 -0700 [thread overview]
Message-ID: <150525509833.16190.13781845219034664184@localhost.localdomain> (raw)
In-Reply-To: <87wp53zs8u.fsf@tesseract.cs.unb.ca>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
The broken commit is in 0.25.1, but this patch isn't correct? It's going to
break alot if that's the case.
Dylan
Quoting David Bremner (2017-09-12 11:28:17)
> Gaute Hope <eg@gaute.vetsj.com> writes:
>
> > The deprecated Database.add_message now calls the new index_file with
> > correct number of arguments (without an extra `self`), and returns the
> > tuple from index_file - as it used to do before.
> >
> > This change also adds a DeprecationWarning to the function.
>
> Pushed to master, thanks
>
> d
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
-----BEGIN PGP SIGNATURE-----
iQEzBAABCAAdFiEEUwPMqo/+5aFHLzU4CJ4WlhQGiO8FAlm4XrcACgkQCJ4WlhQG
iO818QgAltiFIPU8Ti6EkFDRkyzmVzDVDg/cdBjGYPaVTGRoSh0xaoFgM7Eihr3X
+uYroUcxjUEOPTXaHvUzX4zPL1s9uNqsUCczKVO+CLso7UqI37nk6/0//+RxJGzT
x+V9By/ok0hrfIG0eCC350rfyvEk+qge1xMiv2NbqINusU+POrO870pe11PpZSLe
KKmFOxPeaMHTT6RbDL4HpQ+181YzcYmCeVCstFxz89zJVbuEUoJqFutF6u+zjHEx
NIX98h19VmgFSFDGK010/CotsWBDcDypDyn7OcO7q2eJGZiYvr4wv1i2x6TPjzIT
J4FLNBD4A4SrOL77ibTe+kpe3Ktpjw==
=LVxg
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2017-09-12 22:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 7:39 [PATCH] python: deprecated add_message calls index_file correctly and returns result Gaute Hope
2017-08-29 22:00 ` Tomi Ollila
2017-08-30 6:55 ` Gaute Hope
2017-08-30 7:38 ` Tomi Ollila
2017-08-30 8:16 ` [PATCH v2] " Gaute Hope
2017-09-12 16:07 ` Daniel Kahn Gillmor
2017-09-12 18:28 ` David Bremner
2017-09-12 22:24 ` Dylan Baker [this message]
2017-09-12 23:29 ` David Bremner
2017-09-13 15:48 ` Dylan Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150525509833.16190.13781845219034664184@localhost.localdomain \
--to=dylan@pnwbakers.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).