From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 50A8E6DE034D for ; Thu, 24 Aug 2017 23:08:57 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.06 X-Spam-Level: X-Spam-Status: No, score=-0.06 tagged_above=-999 required=5 tests=[AWL=-0.040, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ias_ZMsoOkd8 for ; Thu, 24 Aug 2017 23:08:55 -0700 (PDT) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) by arlo.cworth.org (Postfix) with ESMTPS id 473C56DE0183 for ; Thu, 24 Aug 2017 23:08:54 -0700 (PDT) Received: by mail-lf0-f51.google.com with SMTP id d17so6035646lfe.1 for ; Thu, 24 Aug 2017 23:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaute-vetsj-com.20150623.gappssmtp.com; s=20150623; h=date:from:subject:to:references:in-reply-to:user-agent:message-id :mime-version:content-transfer-encoding; bh=SwKHxWq5jwxMnRxuT5sM/gKz7DpnBUXbP4n8fjso9a0=; b=rxhBct5PiTXg7B6S+FxpQ41a4Uf8LXreI+xxcEkikETF2ha5hwuK1/H2c8pJzcCzf2 7vrOgtTCmW+EctBnijuaVRon+zQMcIZOEUC4fyjXsWaLEc1D5WS77gPSX11ArMmp0V8B E/YFTuxBT6FWhw27JYQckHEEmipynqubdrCgKyjF6HQuPPMkov1Ip3F/f2tYsCBEWWf4 GUkyDSIcr+5i2yrw3/Tyv0Ux+LnhXqVNQliuCfX2N+o5lFZTZxbeCZOCxXgGyV6Uljo0 RtNARaYpVwUT+mEpjbTMPH9WXVo14xuvma47/ggyD455FD7Jl0j6Y/CML8Yb23WuJy74 D8Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:references:in-reply-to :user-agent:message-id:mime-version:content-transfer-encoding; bh=SwKHxWq5jwxMnRxuT5sM/gKz7DpnBUXbP4n8fjso9a0=; b=p2LbioE3YAKK26c6XZrSVF/3FBsVDzn763PePa2V7ZvAfdevst/xycljqL4RjOYAI0 U1g/gzPN9q3s+OI1wrKPKirQWiw45+2AqYrh5PDIs/umUZhB30pYUXsV9U/9s6NUZxSm FIzzhBpUIWNCChsvlXl9m4gAjaXX6DCY6NPntaCAHk9Dx+XiTP7V22T0TmGEw3pxe5/B fnllGAxE1TqSXSrG1/38CXZyxbscbF9vETHqZ8cZQPqV4S+pQSglvvMwc1PWv6MzkxHg /mp8rRJl+r6EgOFFwvKDTt2/6Csa9YClijVEF7L88V5SfbMSncHNNcmKGW545pJ7FXe+ gN5Q== X-Gm-Message-State: AHYfb5gjknNY0hbxb/mgALE66wPLD0pV/rgc4U/Znh1fBfHYEsFwOjSJ AiJ7FQQu769qJSuQ X-Received: by 10.25.78.68 with SMTP id c65mr3913950lfb.41.1503641332586; Thu, 24 Aug 2017 23:08:52 -0700 (PDT) Received: from localhost (cm-84.215.128.252.getinternet.no. [84.215.128.252]) by smtp.gmail.com with ESMTPSA id d192sm919993lfe.89.2017.08.24.23.08.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Aug 2017 23:08:50 -0700 (PDT) Date: Fri, 25 Aug 2017 06:08:47 +0000 From: Gaute Hope Subject: Re: [PATCH] python: open messages in binary mode To: David Bremner , Florian Klink , notmuch@notmuchmail.org References: <20170824213001.22353-1-flokli@flokli.de> <87bmn47h0b.fsf@tethera.net> In-Reply-To: <87bmn47h0b.fsf@tethera.net> User-Agent: astroid/v0.9.1-52-g7eac4137 (https://github.com/astroidmail/astroid) Message-Id: <1503641077.7gk2974n4k.astroid@strange.none> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 06:08:57 -0000 David Bremner writes on august 25, 2017 0:11: > Florian Klink writes: >=20 >> To fix this, read file in binary mode and pass to >> email.message_from_binary_file(fp). >> >=20 > Thanks for the patch, but notmuch is not (yet) python3 only. Apparently > that function is only since python 3.2. I'm not sure if/when we'll drop > python 2.7 support, but not without deprecating it for a few releases. Is there anyone still exclusively on Python 2.7? Perhaps the time is=20 ripe for starting that process? Encoding compatability is an unholy mess=20 to maintain for one Python distro. Is any of alot, afew, etc still on Python 2 only? Regards, Gaute =