unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test: remove remainder of previously killed basic test
@ 2017-08-11 18:31 Yuri Volchkov
  2017-08-18 22:55 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: Yuri Volchkov @ 2017-08-11 18:31 UTC (permalink / raw)
  To: notmuch

In the commit 51cd69feb1d131db7a468e33e0fa2e043caad41e the part of the
test "test runs if prerequisite is satisfied" has been
removed. However, there was a remainder of that test - variable
'haveit'.

Kill it, to not to confuse people.

Signed-off-by: Yuri Volchkov <yuri.volchkov@gmail.com>
---
 test/T000-basic.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/test/T000-basic.sh b/test/T000-basic.sh
index 36a7ca4..a4efa3c 100755
--- a/test/T000-basic.sh
+++ b/test/T000-basic.sh
@@ -23,8 +23,7 @@ test_expect_success ':'
 
 test_begin_subtest 'test runs if prerequisite is satisfied'
 test_set_prereq HAVEIT
-haveit=no
-test_expect_success 'test_have_prereq HAVEIT && haveit=yes'
+test_expect_success 'test_have_prereq HAVEIT'
 
 test_begin_subtest 'tests clean up after themselves'
 clean=no
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] test: remove remainder of previously killed basic test
  2017-08-11 18:31 [PATCH] test: remove remainder of previously killed basic test Yuri Volchkov
@ 2017-08-18 22:55 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2017-08-18 22:55 UTC (permalink / raw)
  To: Yuri Volchkov, notmuch

Yuri Volchkov <yuri.volchkov@gmail.com> writes:

> In the commit 51cd69feb1d131db7a468e33e0fa2e043caad41e the part of the
> test "test runs if prerequisite is satisfied" has been
> removed. However, there was a remainder of that test - variable
> 'haveit'.
>
> Kill it, to not to confuse people.
>

pushed to master

d

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-18 22:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-11 18:31 [PATCH] test: remove remainder of previously killed basic test Yuri Volchkov
2017-08-18 22:55 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).