From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 1D0FF6DE1BF8 for ; Fri, 24 Feb 2017 02:21:17 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.16 X-Spam-Level: X-Spam-Status: No, score=-0.16 tagged_above=-999 required=5 tests=[AWL=-0.140, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XpDKq1mRvpli for ; Fri, 24 Feb 2017 02:21:15 -0800 (PST) Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com [209.85.215.53]) by arlo.cworth.org (Postfix) with ESMTPS id 1EA816DE1BCC for ; Fri, 24 Feb 2017 02:21:14 -0800 (PST) Received: by mail-lf0-f53.google.com with SMTP id l12so7077666lfe.0 for ; Fri, 24 Feb 2017 02:21:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaute-vetsj-com.20150623.gappssmtp.com; s=20150623; h=date:from:subject:to:references:in-reply-to:user-agent:message-id :mime-version:content-transfer-encoding; bh=3GF1Qh8fSHgZ1c2WwByjWv5lco8tejmTD+/9p141yH8=; b=q/8lyzcWzbUaotOObgCTSJ7G+r/3N7cb/d/Q9InZ0Ug5S/52nzqGiJKKKH6ra1HHwm O5RwWc5p8CbU9arL61c7RbA+Hz4fDCSfTwM48nfjbJCsHsfmRoS2D04U0oaEXqgoctDn xu0Pfx+duuh4KqvA5KNp8B1KCrox5YkYpsUzWuAivGb20Yb/y0rsue0wquJIl/uKYFtr uzv4TY6iBsl+tOnS2ILQhyEPx2RZCP9ZXwpGlyXt3C+ezkY0Upr63dmEWQ3u7jilUVvf zxLI+9rWI1+NMAHUshnSJAMUi1P5nYVeUpSRG520u37OTREVnyqUzOYanNyxDgXhIwzZ zowA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:references:in-reply-to :user-agent:message-id:mime-version:content-transfer-encoding; bh=3GF1Qh8fSHgZ1c2WwByjWv5lco8tejmTD+/9p141yH8=; b=AqPcrDtmqXl0AoS7jKRbDGi396mSd3f7zBGYouYHAIttgpl9h5Fdp49z/BUs0LT+rG w6e8tTijMbNv+8T+rqc+B7hCEe2ymO6vmS+WDJVS3FpLCelHjCSdUFFdkkXsPwac0s7V QmG8BfRsn6htxqbFFrv9MQw5ArGGS9S3ylZv7uvCuvr0rQrlCOkrAJ8JdD/+ElY8Xzv3 7h9L0M2A+vYY7qUFvZQvL/p9E6VhbKUDWYKx0N7D0GCNUB9aJIXvz8LJ5W5N1sIe7SSX zpCl2fPKCdns0CMS9vXdG3RlYcZ0Df7SIRQQJ2ryxlehNGlf1a2c6fpcEy45CMBUhzDU aeEQ== X-Gm-Message-State: AMke39nQaTKxrjutuW75zLtmpc9AUj+CrMX2k/36yBxnqDNZNV1tC+LavE9cbKfPe0xyoQ== X-Received: by 10.46.83.88 with SMTP id t24mr505095ljd.20.1487931670853; Fri, 24 Feb 2017 02:21:10 -0800 (PST) Received: from localhost ([128.39.46.106]) by smtp.gmail.com with ESMTPSA id s7sm8597155lja.27.2017.02.24.02.21.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Feb 2017 02:21:09 -0800 (PST) Date: Fri, 24 Feb 2017 10:21:06 +0000 From: Gaute Hope Subject: Re: [RFC patch 2/2] lib: handle DatabaseModifiedError in _n_message_ensure_metadata To: David Bremner , notmuch@notmuchmail.org References: <87y3wx2k3s.fsf@tethera.net> <20170224020048.10718-1-david@tethera.net> <20170224020048.10718-2-david@tethera.net> <87efyo2ti9.fsf@tethera.net> In-Reply-To: <87efyo2ti9.fsf@tethera.net> User-Agent: astroid/v0.7-41-gf493303d (https://github.com/astroidmail/astroid) Message-Id: <1487931600.gabu6r3kvx.astroid@strange.none> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 10:21:17 -0000 David Bremner writes on februar 24, 2017 3:49: > David Bremner writes: >=20 >> The error handling here still needs work. The retry count should be >> handled in more sane way, and both running out of retries and an error >> return from notmuch_database_reopen should be handled. >=20 > Probably the number of retries can be limited to 1, since afaict, reopen > is not going to return any recoverable errors. Does _reopen block if the db is locked? =