* [PATCH] emacs: company: remove two build warnings
@ 2017-01-28 10:19 Mark Walters
2017-02-23 12:58 ` David Bremner
0 siblings, 1 reply; 2+ messages in thread
From: Mark Walters @ 2017-01-28 10:19 UTC (permalink / raw)
To: notmuch
This adds two defvars to avoid two build warnings in the notmuch emacs
code. These were both introduced (by me) in commit 827c28a0.
---
The defvar for notmuch-address-command is clearly correct as that is
defined in notmuch-address so will definitely be defined when this
code is run.
The other, for company-idle-timeout, is slightly less clear, as the
user may not use company. It feels a little unpleasant to be defining
variables outside our namespace but we do the same with
company-backends.
[Incidentally I don't think emacs compiler should complain as the
actual use (line 59) is a macro which does bind the variable in any
case.]
Best wishes
Mark
emacs/notmuch-company.el | 2 ++
1 file changed, 2 insertions(+)
diff --git a/emacs/notmuch-company.el b/emacs/notmuch-company.el
index dca6471..3e12e7a 100644
--- a/emacs/notmuch-company.el
+++ b/emacs/notmuch-company.el
@@ -37,12 +37,14 @@
(declare-function company-mode "company")
(declare-function company-manual-begin "company")
(defvar company-backends)
+(defvar company-idle-delay)
(declare-function notmuch-address-harvest "notmuch-address")
(declare-function notmuch-address-harvest-trigger "notmuch-address")
(declare-function notmuch-address-matching "notmuch-address")
(declare-function notmuch-address--harvest-ready "notmuch-address")
(defvar notmuch-address-completion-headers-regexp)
+(defvar notmuch-address-command)
;;;###autoload
(defun notmuch-company-setup ()
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] emacs: company: remove two build warnings
2017-01-28 10:19 [PATCH] emacs: company: remove two build warnings Mark Walters
@ 2017-02-23 12:58 ` David Bremner
0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2017-02-23 12:58 UTC (permalink / raw)
To: Mark Walters, notmuch
Mark Walters <markwalters1009@gmail.com> writes:
> This adds two defvars to avoid two build warnings in the notmuch emacs
> code. These were both introduced (by me) in commit 827c28a0.
pushed to master
d
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-23 12:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-28 10:19 [PATCH] emacs: company: remove two build warnings Mark Walters
2017-02-23 12:58 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).