* [PATCH] test: wrap 'wc -l' results in arithmetic evaluation to strip whitespace
@ 2017-01-04 22:35 Tomi Ollila
2017-01-18 18:00 ` Jani Nikula
2017-01-28 2:30 ` David Bremner
0 siblings, 2 replies; 3+ messages in thread
From: Tomi Ollila @ 2017-01-04 22:35 UTC (permalink / raw)
To: notmuch; +Cc: tomi.ollila
Some new unwrapped 'wc -l's have been added since Jani's 60e79e3a9f1c8
---
test/T070-insert.sh | 2 +-
test/T580-thread-search.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/T070-insert.sh b/test/T070-insert.sh
index 57472b913964..7fb3b87e4584 100755
--- a/test/T070-insert.sh
+++ b/test/T070-insert.sh
@@ -60,7 +60,7 @@ test_expect_equal_json "$output" "$expected"
test_begin_subtest "Insert duplicate message"
notmuch insert +duptag -unread < "$gen_msg_filename"
-output=$(notmuch search --output=files "subject:insert-subject" | wc -l)
+output=$((`notmuch search --output=files "subject:insert-subject" | wc -l`))
test_expect_equal "$output" 2
test_begin_subtest "Duplicate message does not change tags"
diff --git a/test/T580-thread-search.sh b/test/T580-thread-search.sh
index 6f7106db475a..512559a3aff9 100755
--- a/test/T580-thread-search.sh
+++ b/test/T580-thread-search.sh
@@ -15,7 +15,7 @@ count=0
success=0
for id in $(notmuch search --output=messages '*'); do
count=$((count +1))
- matches=$(notmuch search --output=threads "$id" | wc -l)
+ matches=$((`notmuch search --output=threads "$id" | wc -l`))
if [ "$matches" = 1 ]; then
success=$((success + 1))
fi
--
2.8.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] test: wrap 'wc -l' results in arithmetic evaluation to strip whitespace
2017-01-04 22:35 [PATCH] test: wrap 'wc -l' results in arithmetic evaluation to strip whitespace Tomi Ollila
@ 2017-01-18 18:00 ` Jani Nikula
2017-01-28 2:30 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2017-01-18 18:00 UTC (permalink / raw)
To: Tomi Ollila, notmuch; +Cc: tomi.ollila
On Thu, 05 Jan 2017, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> Some new unwrapped 'wc -l's have been added since Jani's 60e79e3a9f1c8
LGTM
> ---
>
> test/T070-insert.sh | 2 +-
> test/T580-thread-search.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/T070-insert.sh b/test/T070-insert.sh
> index 57472b913964..7fb3b87e4584 100755
> --- a/test/T070-insert.sh
> +++ b/test/T070-insert.sh
> @@ -60,7 +60,7 @@ test_expect_equal_json "$output" "$expected"
>
> test_begin_subtest "Insert duplicate message"
> notmuch insert +duptag -unread < "$gen_msg_filename"
> -output=$(notmuch search --output=files "subject:insert-subject" | wc -l)
> +output=$((`notmuch search --output=files "subject:insert-subject" | wc -l`))
> test_expect_equal "$output" 2
>
> test_begin_subtest "Duplicate message does not change tags"
> diff --git a/test/T580-thread-search.sh b/test/T580-thread-search.sh
> index 6f7106db475a..512559a3aff9 100755
> --- a/test/T580-thread-search.sh
> +++ b/test/T580-thread-search.sh
> @@ -15,7 +15,7 @@ count=0
> success=0
> for id in $(notmuch search --output=messages '*'); do
> count=$((count +1))
> - matches=$(notmuch search --output=threads "$id" | wc -l)
> + matches=$((`notmuch search --output=threads "$id" | wc -l`))
> if [ "$matches" = 1 ]; then
> success=$((success + 1))
> fi
> --
> 2.8.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test: wrap 'wc -l' results in arithmetic evaluation to strip whitespace
2017-01-04 22:35 [PATCH] test: wrap 'wc -l' results in arithmetic evaluation to strip whitespace Tomi Ollila
2017-01-18 18:00 ` Jani Nikula
@ 2017-01-28 2:30 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2017-01-28 2:30 UTC (permalink / raw)
To: Tomi Ollila, notmuch; +Cc: tomi.ollila
Tomi Ollila <tomi.ollila@iki.fi> writes:
> Some new unwrapped 'wc -l's have been added since Jani's 60e79e3a9f1c8
pushed to master,
d
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-28 2:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-04 22:35 [PATCH] test: wrap 'wc -l' results in arithmetic evaluation to strip whitespace Tomi Ollila
2017-01-18 18:00 ` Jani Nikula
2017-01-28 2:30 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).