From: Jani Nikula <jani@nikula.org>
To: Ioan-Adrian Ratiu <adi@adirat.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch-config: replace config reading function
Date: Sun, 6 Nov 2016 11:30:08 +0200 [thread overview]
Message-ID: <1478424609-11233-1-git-send-email-jani@nikula.org> (raw)
In-Reply-To: <20161106000953.23745-1-adi@adirat.com>
> So replace g_key_file_load_from_file with g_key_file_load_from_data which
> gives us much more freedom to read configs from multiple sources.
I see how your function is a drop-in replacement to
g_key_file_load_from_file. However, I really don't like the
proliferation of GError here. Please consider this prep patch first. The
error handling will be easier to follow.
BR,
Jani.
Jani Nikula (1):
cli: abstract config file reading to a separate function
notmuch-config.c | 65 ++++++++++++++++++++++++++++++--------------------------
1 file changed, 35 insertions(+), 30 deletions(-)
--
2.1.4
next prev parent reply other threads:[~2016-11-06 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 0:09 [PATCH] notmuch-config: replace config reading function Ioan-Adrian Ratiu
2016-11-06 9:30 ` Jani Nikula [this message]
2016-11-06 9:30 ` [PATCH] cli: abstract config file reading to a separate function Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478424609-11233-1-git-send-email-jani@nikula.org \
--to=jani@nikula.org \
--cc=adi@adirat.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).