From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id CA1426DE0159 for ; Sat, 5 Nov 2016 06:23:19 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -2.722 X-Spam-Level: X-Spam-Status: No, score=-2.722 tagged_above=-999 required=5 tests=[AWL=-0.412, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j09WgN9iqGgS for ; Sat, 5 Nov 2016 06:23:18 -0700 (PDT) Received: from master.debian.org (master.debian.org [82.195.75.110]) by arlo.cworth.org (Postfix) with ESMTPS id 63ADB6DE00D3 for ; Sat, 5 Nov 2016 06:23:18 -0700 (PDT) Received: from pabs by master.debian.org with local (Exim 4.84_2) (envelope-from ) id 1c30wD-0006Lw-3l; Sat, 05 Nov 2016 13:23:13 +0000 Message-ID: <1478352176.17295.5.camel@debian.org> Subject: Re: [PATCH] cli: consider files vanishing during notmuch new non-fatal From: Paul Wise To: Jani Nikula , David Bremner , notmuch@notmuchmail.org Date: Sat, 05 Nov 2016 21:22:56 +0800 In-Reply-To: <1478350621-17137-1-git-send-email-jani@nikula.org> References: <1478312104.1979.8.camel@debian.org> <1478350621-17137-1-git-send-email-jani@nikula.org> Organization: Debian Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-uUUiutt1BDLsdZdnqS+0" X-Mailer: Evolution 3.22.1-2 Mime-Version: 1.0 X-Mailman-Approved-At: Sat, 05 Nov 2016 13:12:57 -0700 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Nov 2016 13:23:19 -0000 --=-uUUiutt1BDLsdZdnqS+0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2016-11-05 at 14:57 +0200, Jani Nikula wrote: > Add a new exit code for when files vanished, so the caller has a > chance to detect the race and re-run notmuch new to recover. I don't think this is the right approach for two reasons: The exit code you have chosen is still a failure so I will still get notified for a minor issue. I use chronic to detect fail scenarios. This is a pretty normal scenario when you have a mail program open and are auto-running `notmuch new` on a scheduled basis or when new mail arrives. notmuch should just ignore the error and continue as normal. --=20 bye, pabs https://wiki.debian.org/PaulWise --=-uUUiutt1BDLsdZdnqS+0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJYHd0wAAoJEDEWul6f+mmj3zEP/jHKFDT0sz/g2gJ0b+ASFrpT No0rmIW/3RxtQmYzCMAcXCE3EP/hZ3QzCrrDU47nYKOjk4ylXGd+doYP5bdxkjBS wcSunryyejXKAQ/P86SkeHIPap9Js+5PeonQhP16jIf6LiiH6gIwDRXnGyB6JvMx WHRe2Xd091orVDWSlX7xcvl96H0DZhnSRi5h6LwQRFSG4d4et6HeNrpym7IvT4Ko yydAvzfyClu0kXM1IasM/GIT64p+5d+TD+k9u0aDqMFRqfd/hTzw8eDB5nM2zaFX 9JqB55gI/Tzc9+Ill9iJYLDv3xtv/2diEEDdcINjuCzabQ8a1QxTVne1WKc7w1yE QY6vHYvpzxF9Nu4VZpMXEP5On54K0Hrol5jMefgiL2EGOgorUZkxHxT7qoe7z28h gPRrmf/uJoFtSlZ1V0RZZbz5c28p2wBf020USvIPYkEwSAUyDeVeh6jaxc+uzZKh yqCQSscYP0+MOkYsH1U/i5Lz0CS8yGzROXwwmhMsdRP0OrL9mwn0/3+PUu4zv7LP S8tG8zPfCUiB/+fANCl1Vko6DE1HAwnUuU9nRDFzOxtMRfDZTnhaQb5fV/W1OXmh TNSvpSBk967KHoEuyDnj2R1IOBGuKaIjka7XzmzYKfFyDQs5iimMhksZXCFTOut0 edR7yaLYvRAAQoiAkD9C =NIB8 -----END PGP SIGNATURE----- --=-uUUiutt1BDLsdZdnqS+0--