From: Paul Wise <pabs@debian.org>
To: Jani Nikula <jani@nikula.org>, David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: consider files vanishing during notmuch new non-fatal
Date: Sat, 05 Nov 2016 21:22:56 +0800 [thread overview]
Message-ID: <1478352176.17295.5.camel@debian.org> (raw)
In-Reply-To: <1478350621-17137-1-git-send-email-jani@nikula.org>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On Sat, 2016-11-05 at 14:57 +0200, Jani Nikula wrote:
> Add a new exit code for when files vanished, so the caller has a
> chance to detect the race and re-run notmuch new to recover.
I don't think this is the right approach for two reasons:
The exit code you have chosen is still a failure so I will still get
notified for a minor issue. I use chronic to detect fail scenarios.
This is a pretty normal scenario when you have a mail program open and
are auto-running `notmuch new` on a scheduled basis or when new mail
arrives. notmuch should just ignore the error and continue as normal.
--
bye,
pabs
https://wiki.debian.org/PaulWise
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-11-05 13:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 12:46 [Paul Wise] Bug#843127: notmuch: race condition in `notmuch new`? David Bremner
2016-11-04 16:26 ` David Bremner
2016-11-13 1:51 ` Austin Clements
2016-11-14 18:44 ` J. Lewis Muir
2016-11-14 18:59 ` David Bremner
2016-11-04 18:47 ` Jani Nikula
2016-11-05 2:15 ` Paul Wise
2016-11-05 12:57 ` [PATCH] cli: consider files vanishing during notmuch new non-fatal Jani Nikula
2016-11-05 13:22 ` Paul Wise [this message]
2016-11-12 15:39 ` David Bremner
2016-11-12 16:04 ` Brian Sniffen
2016-11-12 16:10 ` David Bremner
2016-11-12 16:15 ` David Bremner
2016-11-12 21:08 ` Brian Sniffen
2016-11-12 21:36 ` David Bremner
2016-11-12 20:35 ` Jani Nikula
2016-11-16 11:43 ` David Bremner
2016-11-21 20:14 ` [PATCH v2] " Jani Nikula
2016-11-26 2:44 ` [PATCH] cli/new: document new exit code David Bremner
2016-11-26 9:17 ` Jani Nikula
2016-11-26 9:18 ` [PATCH] test: check the handling of files vanishing between scandir and indexing Jani Nikula
2016-11-27 9:59 ` [PATCH v2] " Jani Nikula
2016-11-29 2:16 ` David Bremner
2016-11-29 7:31 ` Tomi Ollila
2016-12-03 11:24 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478352176.17295.5.camel@debian.org \
--to=pabs@debian.org \
--cc=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).