From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 46D6D6DE0B2B for ; Wed, 19 Oct 2016 15:33:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.415 X-Spam-Level: X-Spam-Status: No, score=-0.415 tagged_above=-999 required=5 tests=[AWL=-0.093, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.211, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cCfI-fSyivMf for ; Wed, 19 Oct 2016 15:33:53 -0700 (PDT) Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by arlo.cworth.org (Postfix) with ESMTPS id 2F6F06DE0962 for ; Wed, 19 Oct 2016 15:33:53 -0700 (PDT) Received: by mail-pf0-f182.google.com with SMTP id e6so23164639pfk.3 for ; Wed, 19 Oct 2016 15:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=dZXcOtWMBEuSeuLDVpdErOBJFe6CPs1KTWXtus3w6P0=; b=FvgclYZWoRCcGKX2q6Ho4VzDf1+HggG6GCcgMMysYTyqPdXdVxC2LVvyax492Q8/YZ 5m5rGPd8jCpwkzLfqU7c2GLaQVu13Qko3wDMR/CQknlJ1ndLShWRSJcoooBER1PVxQOn GtWRv2LX7gUPGvGP8xx5KiL1FhG9CUEF8YI0C72fcoZIYy7fLs9Z8Y/FBW3C+zi3q13t S2MafuUOSeAUDFGQ2Eno119g41GJpomrFJKug4Nahn93FP4MYWOttC1W0+8uu5jXUe+3 WKlocUUImHiDdZbwkZ7/9/kjxIWePs3mwsZqwxezdiK/2tO4tlRUO62iphmb/ftin3XG q7mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dZXcOtWMBEuSeuLDVpdErOBJFe6CPs1KTWXtus3w6P0=; b=QyhkFGkNvzGVT3p5oJBzqrTy3B8J+9OvY0mX97CxW5BkL5bA8NlgZ2zJMFsW7zFPGy wKHu19tNZyeLe3915KMJfby4qHw00TEOL8JbmplLt/r9etB7Ce4FhQdlVNJ+4v6kAnEr +r4C+1cTz5CFm1WFo733shbjLG+rimpubzkvtTNlGG5KrMZEji9DVRobJwjGmIMwW6h4 X0yVUq5J5oGZlXY5v6RqI3QQcJaEkRlekXg+g4GwwaxGdu+u9beWWfNIwPXQ5i1B1gyn rFJGm0lUJd1opbNku+1mpC8XrlNLZLCCpsEMan6HkcPJVwo1L4o90EqrRwEvtAFWeXTT GWTQ== X-Gm-Message-State: AA6/9Rn5Dz9w+LBf7rJVR0gkHNlH9qrY05Tk/viYZ/XYJbuX2nqVgeSutfwEBfCFcN+Jip3p X-Received: by 10.99.64.132 with SMTP id n126mr12364772pga.87.1476916432567; Wed, 19 Oct 2016 15:33:52 -0700 (PDT) Received: from marmstrong-linux.kir.corp.google.com ([100.119.200.73]) by smtp.gmail.com with ESMTPSA id h185sm35694150pfe.35.2016.10.19.15.33.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Oct 2016 15:33:52 -0700 (PDT) From: Matt Armstrong To: notmuch@notmuchmail.org Subject: [PATCH v1] emacs: make faces clear on dark backgrounds. Date: Wed, 19 Oct 2016 15:31:35 -0700 Message-Id: <1476916295-21148-1-git-send-email-marmstrong@google.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 22:33:54 -0000 The notmuch-tag-flagged and notmucy-search-flagged-face faces defaulted to "blue", which is nearly unreadable when a dark background is in use. This is addressed by using "gold" for dark backgrounds. There is one remaining unconditional use of "blue" at notmuch-crypto-part-header, but I don't have any SMIME email, so I'm unable to see the impact of changing that variable. I've left it alone. --- emacs/notmuch-tag.el | 5 ++++- emacs/notmuch.el | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el index 1b2ce5c..199582b 100644 --- a/emacs/notmuch-tag.el +++ b/emacs/notmuch-tag.el @@ -115,7 +115,10 @@ Used in the default value of `notmuch-tag-formats`." :group 'notmuch-faces) (defface notmuch-tag-flagged - '((t :foreground "blue")) + '((((class color) + (background dark)) + (:foreground "gold")) + (t :foreground "blue")) "Face used for the flagged tag. Used in the default value of `notmuch-tag-formats`." diff --git a/emacs/notmuch.el b/emacs/notmuch.el index bd08aa0..9246344 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -313,7 +313,10 @@ there will be called at other points of notmuch execution." :group 'notmuch-faces) (defface notmuch-search-flagged-face - '((t + '((((class color) + (background dark)) + (:foreground "gold")) + (t (:foreground "blue"))) "Face used in search mode face for flagged threads. -- 2.8.0.rc3.226.g39d4020