From: Matt Armstrong <marmstrong@google.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v1] emacs: make faces clear on dark backgrounds.
Date: Wed, 19 Oct 2016 15:31:35 -0700 [thread overview]
Message-ID: <1476916295-21148-1-git-send-email-marmstrong@google.com> (raw)
The notmuch-tag-flagged and notmucy-search-flagged-face faces defaulted
to "blue", which is nearly unreadable when a dark background is in use.
This is addressed by using "gold" for dark backgrounds.
There is one remaining unconditional use of "blue" at
notmuch-crypto-part-header, but I don't have any SMIME email, so I'm
unable to see the impact of changing that variable. I've left it alone.
---
emacs/notmuch-tag.el | 5 ++++-
emacs/notmuch.el | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
index 1b2ce5c..199582b 100644
--- a/emacs/notmuch-tag.el
+++ b/emacs/notmuch-tag.el
@@ -115,7 +115,10 @@ Used in the default value of `notmuch-tag-formats`."
:group 'notmuch-faces)
(defface notmuch-tag-flagged
- '((t :foreground "blue"))
+ '((((class color)
+ (background dark))
+ (:foreground "gold"))
+ (t :foreground "blue"))
"Face used for the flagged tag.
Used in the default value of `notmuch-tag-formats`."
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index bd08aa0..9246344 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -313,7 +313,10 @@ there will be called at other points of notmuch execution."
:group 'notmuch-faces)
(defface notmuch-search-flagged-face
- '((t
+ '((((class color)
+ (background dark))
+ (:foreground "gold"))
+ (t
(:foreground "blue")))
"Face used in search mode face for flagged threads.
--
2.8.0.rc3.226.g39d4020
reply other threads:[~2016-10-19 22:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476916295-21148-1-git-send-email-marmstrong@google.com \
--to=marmstrong@google.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).