From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 359146DE024A for ; Thu, 13 Oct 2016 19:58:10 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.09 X-Spam-Level: X-Spam-Status: No, score=0.09 tagged_above=-999 required=5 tests=[AWL=0.100, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tBHFb7fZtMwz for ; Thu, 13 Oct 2016 19:58:09 -0700 (PDT) Received: from picnicpark.org (picnicpark.org [130.94.181.238]) by arlo.cworth.org (Postfix) with ESMTP id 41FEA6DE01CE for ; Thu, 13 Oct 2016 19:58:09 -0700 (PDT) Received: (qmail 56515 invoked by uid 13806); 14 Oct 2016 02:58:08 -0000 Received: from unknown (HELO gw.picnicpark.org) (camalot@[108.225.17.54]) (envelope-sender ) by 130.94.181.238 (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 14 Oct 2016 02:58:08 -0000 Received: from kea-tablet.picnicpark.org (gw.picnicpark.org [127.0.0.1]) by gw.picnicpark.org (Postfix) with ESMTPSA id BBB6812A0B37; Thu, 13 Oct 2016 19:57:59 -0700 (PDT) Message-ID: <1476413859.2162.5.camel@picnicpark.org> Subject: Re: [PATCH] Expand docstrings about fcc using notmuch-insert From: Keith Amidon To: David Bremner , notmuch@notmuchmail.org Date: Thu, 13 Oct 2016 19:57:39 -0700 In-Reply-To: <87bmynvhsa.fsf@zancas.localnet> References: <20161011045222.15723-1-camalot@picnicpark.org> <1476398420.2162.1.camel@picnicpark.org> <87bmynvhsa.fsf@zancas.localnet> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 02:58:10 -0000 On Thu, 2016-10-13 at 22:30 -0300, David Bremner wrote: > No technical difficulties, we're just not as good as you think we are > at quick reviews ;). I wanted to hear what Mark felt about exposing > these internals as docstring. I OK with it, but it does make it > slightly harder to change things later. Thanks for getting back to me. In case it helps, part of the reason why I mentioned exactly how it was done was because I wasn't 100% sure I captured the behavior of split-string-and-unquote correctly. I personally found the docstring, elisp manual page, and the source for that function all somewhat opaque. This way if someone ran into a problem trying to quote the folder as I described they would know where to go look for more detail. :-) --- Keith