From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/2] Check for misplaced secure mml tags
Date: Sun, 2 Oct 2016 15:05:29 +0100 [thread overview]
Message-ID: <1475417131-24915-1-git-send-email-markwalters1009@gmail.com> (raw)
This is new (essentially completely rewritten) version of
id:1475008491-28175-1-git-send-email-markwalters1009@gmail.com
This version is stricter in its checking. I believe emacs only
processes a secure tag if it as the start of the body and followed by
a newline. Thus if there is a secure tag anywhere else (including in
the headers), or it is not followed by a newline we query the user.
The logic is a little convoluted but it seems to work in all cases I
have tried.
The extra strictness over the previous version is partly based on
experience from my current (not yet posted) version of the postpone
code. I will store the secure tag in a header while it is saved (so
checking the header seems worth doing), and one version restored the
secure tag. but not on its own line and that caused problems.
We could consider adding other checks later -- generally I think
sending a malformed email is bad but not terrible, but accidentally
sending a message unencrypted is terrible so we should be stricter
here.
Finally, there are other possible corruptions of a secure tag, but
this seems a good start.
Best wishes
Mark
Mark Walters (2):
emacs: mua: extract a common message-send function.
emacs: mua: check for misplaced secure mml tags
emacs/notmuch-mua.el | 38 ++++++++++++++++++++++++++++++++++----
1 file changed, 34 insertions(+), 4 deletions(-)
--
2.1.4
next reply other threads:[~2016-10-02 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-02 14:05 Mark Walters [this message]
2016-10-02 14:05 ` [PATCH 1/2] emacs: mua: extract a common message-send function Mark Walters
2016-10-02 14:05 ` [PATCH 2/2] emacs: mua: check for misplaced secure mml tags Mark Walters
2016-10-08 14:57 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475417131-24915-1-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).