From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id BDFDF6DE09FB for ; Thu, 29 Sep 2016 06:12:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.212 X-Spam-Level: X-Spam-Status: No, score=0.212 tagged_above=-999 required=5 tests=[AWL=0.221, HEADER_FROM_DIFFERENT_DOMAINS=0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jnqi6GbVbNUQ for ; Thu, 29 Sep 2016 06:12:15 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id B0A476DE091C for ; Thu, 29 Sep 2016 06:12:14 -0700 (PDT) Received: by guru.guru-group.fi (Postfix, from userid 501) id 208941000B3; Thu, 29 Sep 2016 16:12:51 +0300 (EEST) From: Tomi Ollila To: notmuch@notmuchmail.org Cc: tomi.ollila@iki.fi Subject: [PATCH] configure: set platform variables also when `uname` is unrecognized Date: Thu, 29 Sep 2016 16:12:49 +0300 Message-Id: <1475154769-14649-1-git-send-email-tomi.ollila@iki.fi> X-Mailer: git-send-email 2.8.2 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 13:12:16 -0000 Since commit 124a67e96ecab5495c0f17b6875d53dfd67ff137: configure: add set -u all variables must be set before their expansion are attempted. These 2 variables: "platform" and "linker_resolves_library_dependencies" were not given value in the final 'else' branch when platform check failed due to unrecognized kernel name (output of `uname`). Now those two are given reasonable non-empty values. --- Unfortunately I did not catch these 2 while doing 124a67e96ecab5; That else branch just skipped my radar. Now I also (re-)looked all other if/then/elif/else/fi parts to catch any other similar potential problems, and did not notice anything. configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index fa4c5b5..cc6746c 100755 --- a/configure +++ b/configure @@ -650,6 +650,8 @@ elif [ $uname = "Linux" ] || [ $uname = "GNU" ] ; then fi else printf "Unknown.\n" + platform="$uname" + linker_resolves_library_dependencies=0 cat <