[PATCH] NEWS: add news for fcc insert and address completion changes

[PATCH] NEWS: add news for fcc insert and address completion changes

[Mark Walters]

---

I think this fixes the comments for the first version of this (see
id:1472997204-15411-1-git-send-email-markwalters1009@gmail.com )

Best wishes

Mark

NEWS | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/NEWS b/NEWS
index 04ab32d..805a034 100644
--- a/NEWS
+++ b/NEWS
@@ -55,6 +55,43 @@ Dump/Restore support for configuration information and properties
 Emacs
 -----
 
+Make notmuch-message-mode use insert for fcc
+
+  Notmuch-message-mode now defaults to using notmuch insert for
+  fcc. The old file based fcc behaviour can be restored by setting the
+  defcustom `notmuch-maildir-use-notmuch-insert` to nil.
+
+  When using notmuch insert, `notmuch-fcc-dirs` must be a subdirectory
+  of the mailstore (absolute paths are not permitted) followed by any
+  tag changes to be applied to the inserted message. The tag changes
+  are applied after the default tagging for new messages. For example
+  setting the header to "sentmail -inbox +sent" would insert the
+  message in the subdirectory sentmail of the mailstore, add the tag
+  "sent", and not add the (normally added) "inbox" tag.
+
+  Finally, if the insert fails (e.g. if the database is locked) the
+  user is presented with the option to retry, ignore, or edit the
+  header.
+
+Make internal address completion customizable
+
+  There is a new defcustom `notmuch-address-internal-completion` which
+  controls how the internal completion works: it allows the user to
+  choose whether to match on messages the user sent, or the user
+  received, and to filter the messages used for the match, for example
+  by date.
+
+Allow internal address completion on an individual basis
+
+  There is a new function `notmuch-address-toggle-internal-completion`
+  (by default it has no keybinding) which allows users who normally
+  use an external completion command to use the builtin internal
+  completion for the current buffer.
+
+  Alternatively, if the user has company-mode enabled, then the user
+  can use company mode commands such as `company-complete` to
+  activate the builtin completion for an individual completion.
+
 Resend messages
 
   The function `notmuch-show-resend-message` (bound to `b` in show
-- 
2.1.4

Re: [PATCH] NEWS: add news for fcc insert and address completion changes

[Tomi Ollila]

On Wed, Sep 28 2016, Mark Walters <markwalters1009@gmail.com> wrote:

> ---
>
> I think this fixes the comments for the first version of this (see
> id:1472997204-15411-1-git-send-email-markwalters1009@gmail.com )

yes. +1

>
> Best wishes
>
> Mark
>
> NEWS | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index 04ab32d..805a034 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -55,6 +55,43 @@ Dump/Restore support for configuration information and properties
>  Emacs
>  -----
>  
> +Make notmuch-message-mode use insert for fcc
> +
> +  Notmuch-message-mode now defaults to using notmuch insert for
> +  fcc. The old file based fcc behaviour can be restored by setting the
> +  defcustom `notmuch-maildir-use-notmuch-insert` to nil.
> +
> +  When using notmuch insert, `notmuch-fcc-dirs` must be a subdirectory
> +  of the mailstore (absolute paths are not permitted) followed by any
> +  tag changes to be applied to the inserted message. The tag changes
> +  are applied after the default tagging for new messages. For example
> +  setting the header to "sentmail -inbox +sent" would insert the
> +  message in the subdirectory sentmail of the mailstore, add the tag
> +  "sent", and not add the (normally added) "inbox" tag.
> +
> +  Finally, if the insert fails (e.g. if the database is locked) the
> +  user is presented with the option to retry, ignore, or edit the
> +  header.
> +
> +Make internal address completion customizable
> +
> +  There is a new defcustom `notmuch-address-internal-completion` which
> +  controls how the internal completion works: it allows the user to
> +  choose whether to match on messages the user sent, or the user
> +  received, and to filter the messages used for the match, for example
> +  by date.
> +
> +Allow internal address completion on an individual basis
> +
> +  There is a new function `notmuch-address-toggle-internal-completion`
> +  (by default it has no keybinding) which allows users who normally
> +  use an external completion command to use the builtin internal
> +  completion for the current buffer.
> +
> +  Alternatively, if the user has company-mode enabled, then the user
> +  can use company mode commands such as `company-complete` to
> +  activate the builtin completion for an individual completion.
> +
>  Resend messages
>  
>    The function `notmuch-show-resend-message` (bound to `b` in show
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] NEWS: add news for fcc insert and address completion changes

[David Bremner]

Mark Walters <markwalters1009@gmail.com> writes:

> ---
>
> I think this fixes the comments for the first version of this (see
> id:1472997204-15411-1-git-send-email-markwalters1009@gmail.com )

pushed to release and master

d

[PATCH] NEWS: add news for fcc insert and address completion changes

[Mark Walters]

---

I am not totally sure about the wording, so any suggestions gratefully
received.

Best wishes

Mark


NEWS | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/NEWS b/NEWS
index 0221414..af4a712 100644
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,43 @@ Notmuch 0.23 (UNRELEASED)
 Emacs
 -----
 
+Make message mode use insert for fcc
+
+  Message mode now defaults to using notmuch insert for fcc. The old
+  file based fcc behaviour can be restored by setting the defcustom
+  `notmuch-maildir-use-notmuch-insert` to nil.
+
+  When using notmuch insert, `notmuch-fcc-dirs` must be a subdirectory
+  of the mailstore (absolute paths are not permitted) followed by any
+  tag changes to be applied to the inserted message. The tag changes
+  are applied after the default tagging for new messages. For example
+  setting the header to "sentmail -inbox +sent" would insert the
+  message in the subdirectoty sentmail of the mailstore, add the tag
+  "sent", and not add the (normally added) "inbox" tag.
+
+  Finally, if the insert fails (e.g. if the database is locked)the
+  user is presented with the option to retry, ignore, or edit the
+  header.
+
+Make address completion customizable
+
+  There is a new defcustom `notmuch-address-internal-completion` which
+  controls how the internal completion works: it allows the user to
+  choose whether to match on messages the user sent, or the user
+  received, and to filter the messages used for the match, for example
+  by date.
+
+Allow internal address completion on an individual basis
+
+  There is a new function `notmuch-address-toggle-internal-completion`
+  (by default it has no keybinding) which allows users who normally
+  use an exteranl completion command to use the builtin internal
+  completion for the current buffer.
+
+  Alternatively, if the user has company-mode enabled, then the user
+  can use company mode commands such as `company-complete` to
+  activate the builtin completion for an individual completion.
+
 Face customization is easier
 
   New faces `notmuch-search-flagged-face` and
-- 
2.1.4

Re: [PATCH] NEWS: add news for fcc insert and address completion changes

[Tomi Ollila]

On Sun, Sep 04 2016, Mark Walters <markwalters1009@gmail.com> wrote:

> ---
>
> I am not totally sure about the wording, so any suggestions gratefully
> received.

I don't know about the wording (and perhaps it does not need to be
"perfect") -- just a few other comments (inline).

(almost forgot, but then i saw 'editting' in another email :)

> Best wishes
>
> Mark
>
>
> NEWS | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index 0221414..af4a712 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -4,6 +4,43 @@ Notmuch 0.23 (UNRELEASED)
>  Emacs
>  -----
>  
> +Make message mode use insert for fcc
> +
> +  Message mode now defaults to using notmuch insert for fcc. The old
> +  file based fcc behaviour can be restored by setting the defcustom
> +  `notmuch-maildir-use-notmuch-insert` to nil.
> +
> +  When using notmuch insert, `notmuch-fcc-dirs` must be a subdirectory
> +  of the mailstore (absolute paths are not permitted) followed by any
> +  tag changes to be applied to the inserted message. The tag changes
> +  are applied after the default tagging for new messages. For example
> +  setting the header to "sentmail -inbox +sent" would insert the
> +  message in the subdirectoty sentmail of the mailstore, add the tag

typo -- subdirectory

> +  "sent", and not add the (normally added) "inbox" tag.
> +
> +  Finally, if the insert fails (e.g. if the database is locked)the

space after ')'

> +  user is presented with the option to retry, ignore, or edit the
> +  header.
> +
> +Make address completion customizable

Make internal address completion customizable


> +
> +  There is a new defcustom `notmuch-address-internal-completion` which
> +  controls how the internal completion works: it allows the user to
> +  choose whether to match on messages the user sent, or the user
> +  received, and to filter the messages used for the match, for example
> +  by date.
> +
> +Allow internal address completion on an individual basis
> +
> +  There is a new function `notmuch-address-toggle-internal-completion`
> +  (by default it has no keybinding) which allows users who normally
> +  use an exteranl completion command to use the builtin internal

typo -- external

> +  completion for the current buffer.
> +
> +  Alternatively, if the user has company-mode enabled, then the user
> +  can use company mode commands such as `company-complete` to
> +  activate the builtin completion for an individual completion.
> +
>  Face customization is easier
>  
>    New faces `notmuch-search-flagged-face` and
> -- 
> 2.1.4

Re: [PATCH] NEWS: add news for fcc insert and address completion changes

[David Bremner]

Mark Walters <markwalters1009@gmail.com> writes:

> ---
>
> I am not totally sure about the wording, so any suggestions gratefully
> received.
>
> Best wishes
>
> Mark
>
>
> NEWS | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index 0221414..af4a712 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -4,6 +4,43 @@ Notmuch 0.23 (UNRELEASED)
>  Emacs
>  -----
>  
> +Make message mode use insert for fcc
> +
> +  Message mode now defaults to using notmuch insert for fcc. The old
> +  file based fcc behaviour can be restored by setting the defcustom
> +  `notmuch-maildir-use-notmuch-insert` to nil.

I think it's confusing to talk about "message mode", since it suggests
we're messing with innocent gnus users. Maybe notmuch-message-mode, or
"message composition mode"

Other than that (and Tomi's typo fixes) it looks ok

d

Re: [PATCH] NEWS: add news for fcc insert and address completion changes

[Jani Nikula]

On Sun, 04 Sep 2016, Mark Walters <markwalters1009@gmail.com> wrote:
> +  When using notmuch insert, `notmuch-fcc-dirs` must be a subdirectory
> +  of the mailstore (absolute paths are not permitted) followed by any
> +  tag changes to be applied to the inserted message. The tag changes
> +  are applied after the default tagging for new messages. For example
> +  setting the header to "sentmail -inbox +sent" would insert the
> +  message in the subdirectoty sentmail of the mailstore, add the tag
> +  "sent", and not add the (normally added) "inbox" tag.

Hrmh, bikeshedding after the fact, but this completely deviates from all
the other tag change customization options in notmuch-emacs. See

notmuch-message-replied-tags
notmuch-archive-tags
notmuch-show-mark-read-tags

BR,
Jani.

Re: [PATCH] NEWS: add news for fcc insert and address completion changes

[Mark Walters]

On Sun, 11 Sep 2016, Jani Nikula <jani@nikula.org> wrote:
> On Sun, 04 Sep 2016, Mark Walters <markwalters1009@gmail.com> wrote:
>> +  When using notmuch insert, `notmuch-fcc-dirs` must be a subdirectory
>> +  of the mailstore (absolute paths are not permitted) followed by any
>> +  tag changes to be applied to the inserted message. The tag changes
>> +  are applied after the default tagging for new messages. For example
>> +  setting the header to "sentmail -inbox +sent" would insert the
>> +  message in the subdirectoty sentmail of the mailstore, add the tag
>> +  "sent", and not add the (normally added) "inbox" tag.
>
> Hrmh, bikeshedding after the fact, but this completely deviates from all
> the other tag change customization options in notmuch-emacs. See

Yes it is different, but it is doing something a little different as it
also has the folder to store things in -- and if we want it to be
editable in message mode then essentially it needed to be a string. It
should also mean that the existing "set fcc based on from address" works
including being able to set the tags.

Best wishes

Mark