Bug#838283: org-mode: notmuch links are unescaped twice

Bug#838283: org-mode: notmuch links are unescaped twice

[David Bremner]

Package: org-mode
Version: 8.3.4-1
Severity: normal
Tags: patch newcomer upstream

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

org-open-at-point calls org-link-unescape on the search term before
invoking org-notmuch-follow-link, so it's a bad idea to call it again
in org-notmuch-follow-link. In particular this breaks links with '%'
in them.

Here is a definition of org-notmuch-follow-link (from org-notmuch.el)
which seems to work.

(defun org-notmuch-follow-link (search)
  "Follow a notmuch link to SEARCH.

Can link to more than one message, if so all matching messages are shown."
  (require 'notmuch)
  (notmuch-show search))


- -- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.6.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages org-mode depends on:
ii  emacs24         24.5+1-7
ii  emacsen-common  2.0.8

Versions of packages org-mode recommends:
ii  texlive-generic-recommended  2016.20160819-2
ii  texlive-latex-recommended    2016.20160819-2

Versions of packages org-mode suggests:
pn  ditaa                      <none>
pn  org-mode-doc               <none>
ii  texlive-fonts-recommended  2016.20160819-2
ii  texlive-latex-extra        2016.20160819-1

- -- no debconf information

-----BEGIN PGP SIGNATURE-----

iQGcBAEBCAAGBQJX387GAAoJEPIClx2kp54sFjkL/RfU0FuMNnY3XqXLR01cybAO
c7yrw5ANvtcmq+B3onOfDaxkW3ZUdKEUzoqLwUs0pitdqBAu+/I4JHsjcdlJgbik
xAMwCHTYeCYqCBSn9PPi6dZF8ciiQnZUyy1sijq5Dhl6vXXJ4h9ZlvGMk2EVuTpf
PEMTYCGAsvn/p6zgKZTBf/CEs8lEnejnHt4zCwvzAm7MujpgrrzDLNF3aMLRMALp
tIcM96E6fg9azXphisiZxxQ0ibEehF/FiPCefjGgzlHKxViD3nrXvAyuzv4WoKGN
3+hQYXm+YensBSCrYOEAkbFXB/BSyCHTx28CEk3oi7zk2dR43Opzc8D4Zv9Dahrs
pZ8jX7mQ3Nv7J25btLlLP95wkrPuY+zRiShhiajeI6Jsl10qXPz1NIeeKgwqkLs6
0uOUlEbg/84z2M3PEF7U3Xq0X53DvE03SOmbUr1MO7128jH7dqoX69+eyCgvMe1c
4MVCVYlbicilleWvVVIDynr+hQCtwoFO8JYbXtBl/w==
=pH5f
-----END PGP SIGNATURE-----