unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: tree: make jump close message pane
@ 2016-09-19  9:39 Mark Walters
  2016-09-19 23:51 ` David Bremner
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mark Walters @ 2016-09-19  9:39 UTC (permalink / raw)
  To: notmuch

j is in the global notmuch keymap bound to notmuch jump. In tree-mode
it makes sense to close the message pane first (otherwise the new
search runs in the small top pane of tree-mode).
---

I think this is essentially a bugfix -- I can't see why someone would
want to keep the message pane open in tree-mode when using notmuch
jump: the broad ethos of tree-mode is that the tree-view and the
message pane are really one window.

Best wishes

Mark




emacs/notmuch-tree.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index 5431384..851e112 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -241,6 +241,8 @@ FUNC."
     (define-key map [remap notmuch-search] 'notmuch-tree-to-search)
     ;; Override because we want to close message pane first.
     (define-key map [remap notmuch-mua-new-mail] (notmuch-tree-close-message-pane-and #'notmuch-mua-new-mail))
+    ;; Override because we want to close message pane first.
+    (define-key map [remap notmuch-jump-search] (notmuch-tree-close-message-pane-and #'notmuch-jump-search))
 
     (define-key map "S" 'notmuch-search-from-tree-current-query)
 
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] emacs: tree: make jump close message pane
  2016-09-19  9:39 [PATCH] emacs: tree: make jump close message pane Mark Walters
@ 2016-09-19 23:51 ` David Bremner
  2016-09-20 16:19 ` Tomi Ollila
  2016-09-24 13:18 ` David Bremner
  2 siblings, 0 replies; 4+ messages in thread
From: David Bremner @ 2016-09-19 23:51 UTC (permalink / raw)
  To: Mark Walters, notmuch

Mark Walters <markwalters1009@gmail.com> writes:

>
> I think this is essentially a bugfix -- I can't see why someone would
> want to keep the message pane open in tree-mode when using notmuch
> jump: the broad ethos of tree-mode is that the tree-view and the
> message pane are really one window.

Agreed, the current behaviour is annoying.

d

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] emacs: tree: make jump close message pane
  2016-09-19  9:39 [PATCH] emacs: tree: make jump close message pane Mark Walters
  2016-09-19 23:51 ` David Bremner
@ 2016-09-20 16:19 ` Tomi Ollila
  2016-09-24 13:18 ` David Bremner
  2 siblings, 0 replies; 4+ messages in thread
From: Tomi Ollila @ 2016-09-20 16:19 UTC (permalink / raw)
  To: Mark Walters, notmuch

On Mon, Sep 19 2016, Mark Walters <markwalters1009@gmail.com> wrote:

> j is in the global notmuch keymap bound to notmuch jump. In tree-mode
> it makes sense to close the message pane first (otherwise the new
> search runs in the small top pane of tree-mode).

looks good plus one

> ---
>
> I think this is essentially a bugfix -- I can't see why someone would
> want to keep the message pane open in tree-mode when using notmuch
> jump: the broad ethos of tree-mode is that the tree-view and the
> message pane are really one window.
>
> Best wishes
>
> Mark
>
>
>
>
> emacs/notmuch-tree.el | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index 5431384..851e112 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -241,6 +241,8 @@ FUNC."
>      (define-key map [remap notmuch-search] 'notmuch-tree-to-search)
>      ;; Override because we want to close message pane first.
>      (define-key map [remap notmuch-mua-new-mail] (notmuch-tree-close-message-pane-and #'notmuch-mua-new-mail))
> +    ;; Override because we want to close message pane first.
> +    (define-key map [remap notmuch-jump-search] (notmuch-tree-close-message-pane-and #'notmuch-jump-search))
>  
>      (define-key map "S" 'notmuch-search-from-tree-current-query)
>  
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] emacs: tree: make jump close message pane
  2016-09-19  9:39 [PATCH] emacs: tree: make jump close message pane Mark Walters
  2016-09-19 23:51 ` David Bremner
  2016-09-20 16:19 ` Tomi Ollila
@ 2016-09-24 13:18 ` David Bremner
  2 siblings, 0 replies; 4+ messages in thread
From: David Bremner @ 2016-09-24 13:18 UTC (permalink / raw)
  To: Mark Walters, notmuch

Mark Walters <markwalters1009@gmail.com> writes:

> j is in the global notmuch keymap bound to notmuch jump. In tree-mode
> it makes sense to close the message pane first (otherwise the new
> search runs in the small top pane of tree-mode).

pushed,

d

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-24 13:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-19  9:39 [PATCH] emacs: tree: make jump close message pane Mark Walters
2016-09-19 23:51 ` David Bremner
2016-09-20 16:19 ` Tomi Ollila
2016-09-24 13:18 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).