From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH] add has: query prefix to search for specific properties
Date: Fri, 8 Jul 2016 11:15:36 +0200 [thread overview]
Message-ID: <1467969336-7605-1-git-send-email-dkg@fifthhorseman.net> (raw)
In-Reply-To: <1465779955-5539-9-git-send-email-david@tethera.net>
We want to be able to query the properties directly, like:
notmuch count has:foo=bar
which should return a count of messages where the property with key
"foo" has value equal to "bar".
This patch could be improved:
If no = sign is present (e.g. "has:foo"), it'd be nice to just match
on every message that has property "foo", regardless of value.
It would also be good to include some tests.
---
lib/database.cc | 4 ++++
1 file changed, 4 insertions(+)
This applies atop bermner's "message properties" series, and makes it
possible to query for messages with specific properties.
diff --git a/lib/database.cc b/lib/database.cc
index 3a741f0..3bdbd07 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -97,6 +97,9 @@ typedef struct {
* STRING is the name of a file within that
* directory for this mail message.
*
+ * has: Has a property with key=value
+ * FIXME: if no = is present, should match on any value
+ *
* A mail document also has four values:
*
* TIMESTAMP: The time_t value corresponding to the message's
@@ -260,6 +263,7 @@ static prefix_t BOOLEAN_PREFIX_EXTERNAL[] = {
{ "is", "K" },
{ "id", "Q" },
{ "path", "P" },
+ { "has", "XPROPERTY" },
/*
* Without the ":", since this is a multi-letter prefix, Xapian
* will add a colon itself if the first letter of the path is
--
2.8.1
next prev parent reply other threads:[~2016-07-08 10:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 1:05 message properties patches, v1.0 David Bremner
2016-06-13 1:05 ` [PATCH 1/8] lib: read "property" terms from messages David Bremner
2016-06-13 1:05 ` [PATCH 2/8] lib: private string map (associative array) API David Bremner
2016-06-13 8:10 ` Tomi Ollila
2016-06-13 13:02 ` David Bremner
2016-06-13 15:18 ` Bijan Chokoufe Nejad
2016-06-13 1:05 ` [PATCH 3/8] lib: basic message-property API David Bremner
2016-07-08 4:36 ` [PATCH] n_m_remove_property(msg, key, NULL) should removes all properties with key Daniel Kahn Gillmor
2016-07-16 10:32 ` [PATCH] RFC: all deleting all properties with a given key David Bremner
2016-07-17 23:33 ` Daniel Kahn Gillmor
2016-06-13 1:05 ` [PATCH 4/8] lib: extend private string map API with iterators David Bremner
2016-06-13 1:05 ` [PATCH 5/8] lib: iterator API for message properties David Bremner
2016-06-13 1:05 ` [PATCH 6/8] CLI: refactor dumping of tags David Bremner
2016-06-13 1:05 ` [PATCH 7/8] CLI: add properties to dump output David Bremner
2016-06-13 1:05 ` [PATCH 8/8] cli: optionally restore message properties from dump file David Bremner
2016-07-08 9:15 ` Daniel Kahn Gillmor [this message]
2016-07-17 0:39 ` [PATCH] add has: query prefix to search for specific properties David Bremner
2016-07-17 10:38 ` David Bremner
2016-07-17 23:44 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467969336-7605-1-git-send-email-dkg@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).