LIBNOTMUCH_CHECK_VERSION macro broken

LIBNOTMUCH_CHECK_VERSION macro broken

[Richard Russon]

In <notmuch.h> the macro definition begins:

#define LIBNOTMUCH_CHECK_VERSION (major, minor, micro)

There shouldn't be a space before the (

This is from the current version in git.

Cheers,
    Rich / FlatCap

[PATCH] lib: fix definition of LIBNOTMUCH_CHECK_VERSION

[David Bremner]

Fix bug reported in id:20160606124522.g2y2eazhhrwjsa4h@flatcap.org

Although the C99 standard 6.10 is a little non-obvious on this point,
the docs for e.g. gcc are unambiguous. And indeed in practice with the
extra space, this code fails

int main(int argc, char **argv){
  printf("%d\n",foo(1));
}
---
 lib/notmuch.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/notmuch.h b/lib/notmuch.h
index 29713ae..d4a97cb 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -93,7 +93,7 @@ NOTMUCH_BEGIN_DECLS
  * #endif
  * @endcode
  */
-#define LIBNOTMUCH_CHECK_VERSION (major, minor, micro)			\
+#define LIBNOTMUCH_CHECK_VERSION(major, minor, micro)			\
     (LIBNOTMUCH_MAJOR_VERSION > (major) ||					\
      (LIBNOTMUCH_MAJOR_VERSION == (major) && LIBNOTMUCH_MINOR_VERSION > (minor)) || \
      (LIBNOTMUCH_MAJOR_VERSION == (major) && LIBNOTMUCH_MINOR_VERSION == (minor) && \
-- 
2.1.4

Re: [PATCH] lib: fix definition of LIBNOTMUCH_CHECK_VERSION

[David Bremner]

David Bremner <david@tethera.net> writes:

> Fix bug reported in id:20160606124522.g2y2eazhhrwjsa4h@flatcap.org
>
> Although the C99 standard 6.10 is a little non-obvious on this point,
> the docs for e.g. gcc are unambiguous. And indeed in practice with the
> extra space, this code fails
>
> int main(int argc, char **argv){
>   printf("%d\n",foo(1));
> }
> ---

Of course git removed the #define as a comment. sigh.

d

[PATCH] lib: fix definition of LIBNOTMUCH_CHECK_VERSION

[David Bremner]

Fix bug reported in id:20160606124522.g2y2eazhhrwjsa4h@flatcap.org

Although the C99 standard 6.10 is a little non-obvious on this point,
the docs for e.g. gcc are unambiguous. And indeed in practice with the
extra space, this code fails

#include <stdio.h>
#define foo (x) (x+1)

int main(int argc, char **argv){
  printf("%d\n",foo(1));
}
---
 lib/notmuch.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/notmuch.h b/lib/notmuch.h
index 29713ae..d4a97cb 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -93,7 +93,7 @@ NOTMUCH_BEGIN_DECLS
  * #endif
  * @endcode
  */
-#define LIBNOTMUCH_CHECK_VERSION (major, minor, micro)			\
+#define LIBNOTMUCH_CHECK_VERSION(major, minor, micro)			\
     (LIBNOTMUCH_MAJOR_VERSION > (major) ||					\
      (LIBNOTMUCH_MAJOR_VERSION == (major) && LIBNOTMUCH_MINOR_VERSION > (minor)) || \
      (LIBNOTMUCH_MAJOR_VERSION == (major) && LIBNOTMUCH_MINOR_VERSION == (minor) && \
-- 
2.8.1

Re: [PATCH] lib: fix definition of LIBNOTMUCH_CHECK_VERSION

[David Bremner]

David Bremner <david@tethera.net> writes:

> Fix bug reported in id:20160606124522.g2y2eazhhrwjsa4h@flatcap.org
>
> Although the C99 standard 6.10 is a little non-obvious on this point,
> the docs for e.g. gcc are unambiguous. And indeed in practice with the
> extra space, this code fails
>

Pushed to master.

d