From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: [PATCH] configure: add set -u
Date: Fri, 6 May 2016 21:11:25 +0300 [thread overview]
Message-ID: <1462558285-10936-1-git-send-email-tomi.ollila@iki.fi> (raw)
In-Reply-To: <1462296224-768-1-git-send-email-tomi.ollila@iki.fi>
In case of any unset variable, make ./configure exit with nonzero value;
an attempt to expand an unset variable is a bug in the script
(usually a spelling mistake) and those should not pass through
unnoticed.
---
I was also doing set -e support but that has quite a few nontrivial
things in it. Set -u catches all lagging c++ compilers and so on ;).
Perhaps later.
This change requires id:1462296224-768-1-git-send-email-tomi.ollila@iki.fi
to be applied first, otherwise ./configure will not pass.
configure | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 6231d2b..3753e7f 100755
--- a/configure
+++ b/configure
@@ -1,5 +1,7 @@
#! /bin/sh
+set -u
+
# Test whether this shell is capable of parameter substring processing.
( option='a/b'; : ${option#*/} ) 2>/dev/null || {
echo "
@@ -480,6 +482,7 @@ if pkg-config --exists valgrind; then
else
printf "No (but that's fine).\n"
have_valgrind=0
+ valgrind_cflags=
fi
printf "Checking for bash-completion (>= 1.90)... "
@@ -490,11 +493,11 @@ else
WITH_BASH=0
fi
-if [ -z "${EMACSLISPDIR}" ]; then
+if [ -z "${EMACSLISPDIR-}" ]; then
EMACSLISPDIR="\$(prefix)/share/emacs/site-lisp"
fi
-if [ -z "${EMACSETCDIR}" ]; then
+if [ -z "${EMACSETCDIR-}" ]; then
EMACSETCDIR="\$(prefix)/share/emacs/site-lisp"
fi
--
2.8.2
next prev parent reply other threads:[~2016-05-06 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 17:23 [PATCH] configure: replace ${CXXLAGS} with ${CXXFLAGS_for_sh} Tomi Ollila
2016-05-06 18:11 ` Tomi Ollila [this message]
2016-05-07 22:27 ` [PATCH] configure: add set -u David Bremner
2016-09-29 11:41 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462558285-10936-1-git-send-email-tomi.ollila@iki.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).