[PATCH] bindings: drop build time message on missing ruby dependency

[PATCH] bindings: drop build time message on missing ruby dependency

[Jani Nikula]

The usual make message on everything being up to date is:

	make: Nothing to be done for 'all'.

However, since

commit d038b9320949c79503fe4b76870aaabf279405ab
Author: David Bremner <david@tethera.net>
Date:   Mon Jun 1 09:08:59 2015 +0200

    build: integrate building ruby bindings into notmuch build process

if one doesn't have the ruby dependencies installed, the message has
been:

	Missing dependency, skipping ruby bindings

Restore the usual behaviour by dropping the message. It's redundant
during build anyway, since the configure script already outputs:

	Checking for ruby development files... No (skipping ruby bindings)
---
 bindings/Makefile.local | 2 --
 1 file changed, 2 deletions(-)

diff --git a/bindings/Makefile.local b/bindings/Makefile.local
index 4ecf839d7c18..11d11d4bcbeb 100644
--- a/bindings/Makefile.local
+++ b/bindings/Makefile.local
@@ -10,8 +10,6 @@ ifeq ($(HAVE_RUBY_DEV),1)
 		LIBNOTMUCH="../../lib/$(LINKER_NAME)" \
 		ruby extconf.rb --vendor
 	$(MAKE) -C $(dir)/ruby
-else
-	@echo Missing dependency, skipping ruby bindings
 endif
 
 CLEAN += $(patsubst %,$(dir)/ruby/%, \
-- 
2.1.4

Re: [PATCH] bindings: drop build time message on missing ruby dependency

[Tomi Ollila]

On Wed, Apr 13 2016, Jani Nikula <jani@nikula.org> wrote:


LGTM.

Tomi


> The usual make message on everything being up to date is:
>
> 	make: Nothing to be done for 'all'.
>
> However, since
>
> commit d038b9320949c79503fe4b76870aaabf279405ab
> Author: David Bremner <david@tethera.net>
> Date:   Mon Jun 1 09:08:59 2015 +0200
>
>     build: integrate building ruby bindings into notmuch build process
>
> if one doesn't have the ruby dependencies installed, the message has
> been:
>
> 	Missing dependency, skipping ruby bindings
>
> Restore the usual behaviour by dropping the message. It's redundant
> during build anyway, since the configure script already outputs:
>
> 	Checking for ruby development files... No (skipping ruby bindings)
> ---
>  bindings/Makefile.local | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/bindings/Makefile.local b/bindings/Makefile.local
> index 4ecf839d7c18..11d11d4bcbeb 100644
> --- a/bindings/Makefile.local
> +++ b/bindings/Makefile.local
> @@ -10,8 +10,6 @@ ifeq ($(HAVE_RUBY_DEV),1)
>  		LIBNOTMUCH="../../lib/$(LINKER_NAME)" \
>  		ruby extconf.rb --vendor
>  	$(MAKE) -C $(dir)/ruby
> -else
> -	@echo Missing dependency, skipping ruby bindings
>  endif
>  
>  CLEAN += $(patsubst %,$(dir)/ruby/%, \
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] bindings: drop build time message on missing ruby dependency

[David Bremner]

Jani Nikula <jani@nikula.org> writes:

> The usual make message on everything being up to date is:
>
> 	make: Nothing to be done for 'all'.
>

pushed,

d