From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH 1/2] verify during thread-breakage that messages are removed as well
Date: Fri, 1 Apr 2016 20:31:54 -0300 [thread overview]
Message-ID: <1459553515-18802-1-git-send-email-dkg@fifthhorseman.net> (raw)
In-Reply-To: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net>
One risk of fixes to the thread-breakage problem is that we could fail
to remove the search term indexes entirely. These additional subtests
should guard against that.
---
| 17 +++++++++++++++++
1 file changed, 17 insertions(+)
--git a/test/T590-thread-breakage.sh b/test/T590-thread-breakage.sh
index 704f504..f3e725c 100755
--- a/test/T590-thread-breakage.sh
+++ b/test/T590-thread-breakage.sh
@@ -17,6 +17,7 @@ To: Bob <bob@example.net>
Date: Thu, 31 Mar 2016 20:10:00 -0400
This is the first message in the thread.
+Apple
EOF
}
@@ -32,10 +33,18 @@ To: Alice <alice@example.net>
Date: Thu, 31 Mar 2016 20:15:00 -0400
This is the second message in the thread.
+Banana
EOF
}
+test_subject_count() {
+ notmuch new >/dev/null
+ test_begin_subtest "${3:-looking for $2 instance of '$1'}"
+ count=$(notmuch count --output=threads "$1")
+ test_expect_equal "$count" "$2"
+}
+
test_thread_count() {
notmuch new >/dev/null
test_begin_subtest "${2:-Expecting $1 thread(s)}"
@@ -47,17 +56,25 @@ test_thread_count 0 'There should be no threads initially'
message_a
test_thread_count 1 'One message in: one thread'
+test_subject_count apple 1
+test_subject_count banana 0
message_b
test_thread_count 1 'Second message in the same thread: one thread'
+test_subject_count apple 1
+test_subject_count banana 1
rm -f ${MAIL_DIR}/cur/a
test_thread_count 1 'First message removed: still only one thread'
+test_subject_count apple 0
+test_subject_count banana 1
message_a
# this is known to fail (it shows 2 threads) because no "ghost
# message" was created for message A when it was removed from the
# index, despite message B still pointing to it.
test_thread_count 1 'First message reappears: should return to the same thread'
+test_subject_count apple 1
+test_subject_count banana 1
test_done
--
2.8.0.rc3
next prev parent reply other threads:[~2016-04-02 1:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 17:34 [PATCH] test thread breakage when messages are removed and re-added Daniel Kahn Gillmor
2016-04-01 22:27 ` Daniel Kahn Gillmor
2016-04-01 23:31 ` Daniel Kahn Gillmor [this message]
2016-04-01 23:31 ` [PATCH 2/2] fix thread breakage via ghost-on-removal Daniel Kahn Gillmor
2016-04-02 14:15 ` [PATCH v2 1/7] test thread breakage when messages are removed and re-added Daniel Kahn Gillmor
2016-04-02 14:15 ` [PATCH v2 2/7] verify during thread-breakage that messages are removed as well Daniel Kahn Gillmor
2016-04-06 1:20 ` David Bremner
2016-04-09 1:54 ` Daniel Kahn Gillmor
2016-04-02 14:15 ` [PATCH v2 3/7] fix thread breakage via ghost-on-removal Daniel Kahn Gillmor
2016-04-05 6:53 ` Tomi Ollila
2016-04-05 20:05 ` Daniel Kahn Gillmor
2016-04-05 23:33 ` David Bremner
2016-04-06 1:39 ` David Bremner
2016-04-02 14:15 ` [PATCH v2 4/7] Add internal functions to search for alternate doc types Daniel Kahn Gillmor
2016-04-06 1:52 ` David Bremner
2016-04-02 14:15 ` [PATCH v2 5/7] Introduce _notmuch_message_has_term() Daniel Kahn Gillmor
2016-04-06 2:04 ` David Bremner
2016-04-02 14:15 ` [PATCH v2 6/7] On deletion, replace with ghost when other active messages in thread Daniel Kahn Gillmor
2016-04-02 14:15 ` [PATCH v2 7/7] complete ghost-on-removal-when-shared-thread-exists Daniel Kahn Gillmor
2016-04-02 16:19 ` [PATCH 1/2] test thread breakage when messages are removed and re-added David Bremner
2016-04-02 16:19 ` [PATCH 2/2] test: add test-binary to print the number of ghost messages David Bremner
2016-04-09 1:02 ` [PATCH v3 1/7] " Daniel Kahn Gillmor
2016-04-09 1:02 ` [PATCH v3 2/7] test thread breakage when messages are removed and re-added Daniel Kahn Gillmor
2016-04-09 1:02 ` [PATCH v3 3/7] fix thread breakage via ghost-on-removal Daniel Kahn Gillmor
2016-04-09 1:02 ` [PATCH v3 4/7] Add internal functions to search for alternate doc types Daniel Kahn Gillmor
2016-04-09 1:02 ` [PATCH v3 5/7] Introduce _notmuch_message_has_term() Daniel Kahn Gillmor
2016-04-09 1:02 ` [PATCH v3 6/7] On deletion, replace with ghost when other active messages in thread Daniel Kahn Gillmor
2016-04-09 1:02 ` [PATCH v3 7/7] complete ghost-on-removal-when-shared-thread-exists Daniel Kahn Gillmor
2016-04-09 1:54 ` [PATCH v4 1/7] test: add test-binary to print the number of ghost messages Daniel Kahn Gillmor
2016-04-09 1:54 ` [PATCH v4 2/7] test thread breakage when messages are removed and re-added Daniel Kahn Gillmor
2016-04-11 13:59 ` [PATCH] remove debugging spew from T590 Daniel Kahn Gillmor
2016-04-09 1:54 ` [PATCH v4 3/7] fix thread breakage via ghost-on-removal Daniel Kahn Gillmor
2016-04-09 1:54 ` [PATCH v4 4/7] Add internal functions to search for alternate doc types Daniel Kahn Gillmor
2016-04-09 1:54 ` [PATCH v4 5/7] Introduce _notmuch_message_has_term() Daniel Kahn Gillmor
2016-04-09 1:54 ` [PATCH v4 6/7] On deletion, replace with ghost when other active messages in thread Daniel Kahn Gillmor
2016-04-09 1:54 ` [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists Daniel Kahn Gillmor
2016-04-09 11:31 ` David Bremner
2016-04-09 18:55 ` Daniel Kahn Gillmor
2016-04-09 19:15 ` David Bremner
2016-04-10 8:35 ` Tomi Ollila
2016-04-11 0:33 ` David Bremner
2016-04-11 19:18 ` Daniel Kahn Gillmor
2016-04-12 1:28 ` David Bremner
2016-04-15 10:29 ` David Bremner
2016-04-20 3:36 ` Austin Clements
2016-04-09 11:02 ` [PATCH v4 1/7] test: add test-binary to print the number of ghost messages David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459553515-18802-1-git-send-email-dkg@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).