* Content-type of the mime part in cited text when replying
@ 2016-03-15 9:59 Nicolas Petton
2016-03-15 12:04 ` David Edmondson
0 siblings, 1 reply; 10+ messages in thread
From: Nicolas Petton @ 2016-03-15 9:59 UTC (permalink / raw)
To: notmuch
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
Hi,
Using Notmuch from Melpa (build 20160314.1554), when replying to an
email, I get at the beginning of the citation the content-type of the
mime part. It looks like the following:
John Doe <john@doe.com> writes:
> [ text/plain ]
> hello there
Nico
--
Nicolas Petton
http://nicolas-petton.fr
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Content-type of the mime part in cited text when replying
2016-03-15 9:59 Content-type of the mime part in cited text when replying Nicolas Petton
@ 2016-03-15 12:04 ` David Edmondson
2016-03-15 12:07 ` Tomi Ollila
2016-03-16 8:10 ` Content-type of the mime part in cited text when replying Nicolas Petton
0 siblings, 2 replies; 10+ messages in thread
From: David Edmondson @ 2016-03-15 12:04 UTC (permalink / raw)
To: Nicolas Petton, notmuch
On Tue, Mar 15 2016, Nicolas Petton wrote:
> Hi,
>
> Using Notmuch from Melpa (build 20160314.1554), when replying to an
> email, I get at the beginning of the citation the content-type of the
> mime part. It looks like the following:
>
> John Doe <john@doe.com> writes:
>
> > [ text/plain ]
> > hello there
(setq notmuch-mua-reply-insert-header-p-function
'notmuch-show-reply-insert-header-p-never)
The documentation for notmuch-mua-reply-insert-header-p-function
describes other options.
We should probably change back to this ("-never") as the default.
> Nico
> --
> Nicolas Petton
> http://nicolas-petton.fr
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Content-type of the mime part in cited text when replying
2016-03-15 12:04 ` David Edmondson
@ 2016-03-15 12:07 ` Tomi Ollila
2016-03-15 12:11 ` David Edmondson
2016-03-16 8:10 ` Content-type of the mime part in cited text when replying Nicolas Petton
1 sibling, 1 reply; 10+ messages in thread
From: Tomi Ollila @ 2016-03-15 12:07 UTC (permalink / raw)
To: David Edmondson, Nicolas Petton, notmuch
> [ text/plain ]
>>
>> John Doe <john@doe.com> writes:
>>
>> > [ text/plain ]
>> > hello there
>
> (setq notmuch-mua-reply-insert-header-p-function
> 'notmuch-show-reply-insert-header-p-never)
>
> The documentation for notmuch-mua-reply-insert-header-p-function
> describes other options.
>
> We should probably change back to this ("-never") as the default.
s/probably //
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Content-type of the mime part in cited text when replying
2016-03-15 12:07 ` Tomi Ollila
@ 2016-03-15 12:11 ` David Edmondson
2016-03-16 8:23 ` Nicolas Petton
0 siblings, 1 reply; 10+ messages in thread
From: David Edmondson @ 2016-03-15 12:11 UTC (permalink / raw)
To: Tomi Ollila, Nicolas Petton, notmuch
On Tue, Mar 15 2016, Tomi Ollila wrote:
>> [ text/plain ]
>>>
>>> John Doe <john@doe.com> writes:
>>>
>>> > [ text/plain ]
>>> > hello there
>>
>> (setq notmuch-mua-reply-insert-header-p-function
>> 'notmuch-show-reply-insert-header-p-never)
>>
>> The documentation for notmuch-mua-reply-insert-header-p-function
>> describes other options.
>>
>> We should probably change back to this ("-never") as the default.
>
> s/probably //
I'd be happy to "+1" a patch :-)
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Content-type of the mime part in cited text when replying
2016-03-15 12:11 ` David Edmondson
@ 2016-03-16 8:23 ` Nicolas Petton
2016-03-16 8:57 ` Tomi Ollila
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Nicolas Petton @ 2016-03-16 8:23 UTC (permalink / raw)
To: David Edmondson, Tomi Ollila, notmuch
[-- Attachment #1.1: Type: text/plain, Size: 96 bytes --]
David Edmondson <dme@dme.org> writes:
> I'd be happy to "+1" a patch :-)
I attached a patch.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-emacs-Change-the-default-notmuch-mua-reply-insert-he.patch --]
[-- Type: text/x-patch, Size: 1695 bytes --]
From 0b809886913c9410f030cf2c6cfdf619ab5c82b7 Mon Sep 17 00:00:00 2001
From: Nicolas Petton <nicolas@petton.fr>
Date: Wed, 16 Mar 2016 09:19:55 +0100
Subject: [PATCH] emacs: Change the default
notmuch-mua-reply-insert-header-p-function
Set notmuch-show-reply-insert-header-p-never as the default value for
notmuch-mua-reply-insert-header-p-function.
---
emacs/notmuch-mua.el | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index fcb3e95..4cb714a 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -94,19 +94,19 @@ Note that these functions use `mail-citation-hook' if that is non-nil."
:group 'notmuch-reply)
(defcustom notmuch-mua-reply-insert-header-p-function
- 'notmuch-show-reply-insert-header-p-trimmed
+ 'notmuch-show-reply-insert-header-p-never
"Function to decide which parts get a header when replying.
This function specifies which parts of a mime message with
mutiple parts get a header."
- :type '(radio (const :tag "All except multipart/* and hidden parts"
- notmuch-show-reply-insert-header-p-trimmed)
+ :type '(radio (const :tag "No part headers"
+ notmuch-show-reply-insert-header-p-never)
+ (const :tag "All except multipart/* and hidden parts"
+ notmuch-show-reply-insert-header-p-trimmed)
(const :tag "Only for included text parts"
notmuch-show-reply-insert-header-p-minimal)
(const :tag "Exactly as in show view"
notmuch-show-insert-header-p)
- (const :tag "No part headers"
- notmuch-show-reply-insert-header-p-never)
(function :tag "Other"))
:group 'notmuch-reply)
--
2.5.0
[-- Attachment #3: Type: text/plain, Size: 50 bytes --]
Nico
--
Nicolas Petton
http://nicolas-petton.fr
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: Content-type of the mime part in cited text when replying
2016-03-16 8:23 ` Nicolas Petton
@ 2016-03-16 8:57 ` Tomi Ollila
2016-03-18 21:25 ` David Bremner
2016-03-19 15:50 ` [PATCH] test/test-lib.el: revert setting notmuch-mua-reply-insert-header-p-function Tomi Ollila
2 siblings, 0 replies; 10+ messages in thread
From: Tomi Ollila @ 2016-03-16 8:57 UTC (permalink / raw)
To: Nicolas Petton, David Edmondson, notmuch
On Wed, Mar 16 2016, Nicolas Petton <nicolas@petton.fr> wrote:
> [ text/plain ]
> David Edmondson <dme@dme.org> writes:
>
>> I'd be happy to "+1" a patch :-)
>
> I attached a patch.
Tis is so complicated... >;)
... anyway if this is bätter than the Dme's alternative,
then the test robustness I mentioned in id:m2a8lyajlo.fsf@guru.guru-group.fi
should also be applied
Tomi
>
> [ signature.asc: application/pgp-signature ]
> [ 0001-emacs-Change-the-default-notmuch-mua-reply-insert-he.patch: text/x-patch ]
> From 0b809886913c9410f030cf2c6cfdf619ab5c82b7 Mon Sep 17 00:00:00 2001
> From: Nicolas Petton <nicolas@petton.fr>
> Date: Wed, 16 Mar 2016 09:19:55 +0100
> Subject: [PATCH] emacs: Change the default
> notmuch-mua-reply-insert-header-p-function
>
> Set notmuch-show-reply-insert-header-p-never as the default value for
> notmuch-mua-reply-insert-header-p-function.
> ---
> emacs/notmuch-mua.el | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index fcb3e95..4cb714a 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -94,19 +94,19 @@ Note that these functions use `mail-citation-hook' if that is non-nil."
> :group 'notmuch-reply)
>
> (defcustom notmuch-mua-reply-insert-header-p-function
> - 'notmuch-show-reply-insert-header-p-trimmed
> + 'notmuch-show-reply-insert-header-p-never
> "Function to decide which parts get a header when replying.
>
> This function specifies which parts of a mime message with
> mutiple parts get a header."
> - :type '(radio (const :tag "All except multipart/* and hidden parts"
> - notmuch-show-reply-insert-header-p-trimmed)
> + :type '(radio (const :tag "No part headers"
> + notmuch-show-reply-insert-header-p-never)
> + (const :tag "All except multipart/* and hidden parts"
> + notmuch-show-reply-insert-header-p-trimmed)
> (const :tag "Only for included text parts"
> notmuch-show-reply-insert-header-p-minimal)
> (const :tag "Exactly as in show view"
> notmuch-show-insert-header-p)
> - (const :tag "No part headers"
> - notmuch-show-reply-insert-header-p-never)
> (function :tag "Other"))
> :group 'notmuch-reply)
>
> --
> 2.5.0
>
> [ text/plain ]
>
> Nico
> --
> Nicolas Petton
> http://nicolas-petton.fr
> [ text/plain ]
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Content-type of the mime part in cited text when replying
2016-03-16 8:23 ` Nicolas Petton
2016-03-16 8:57 ` Tomi Ollila
@ 2016-03-18 21:25 ` David Bremner
2016-03-19 15:50 ` [PATCH] test/test-lib.el: revert setting notmuch-mua-reply-insert-header-p-function Tomi Ollila
2 siblings, 0 replies; 10+ messages in thread
From: David Bremner @ 2016-03-18 21:25 UTC (permalink / raw)
To: Nicolas Petton, David Edmondson, Tomi Ollila, notmuch
Nicolas Petton <nicolas@petton.fr> writes:
> David Edmondson <dme@dme.org> writes:
>
>> I'd be happy to "+1" a patch :-)
>
> I attached a patch.
>
I think Nicolas' version is fine, it just shuffles the custom options
around so the default one is first.
d
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] test/test-lib.el: revert setting notmuch-mua-reply-insert-header-p-function
2016-03-16 8:23 ` Nicolas Petton
2016-03-16 8:57 ` Tomi Ollila
2016-03-18 21:25 ` David Bremner
@ 2016-03-19 15:50 ` Tomi Ollila
2016-03-26 12:11 ` David Bremner
2 siblings, 1 reply; 10+ messages in thread
From: Tomi Ollila @ 2016-03-19 15:50 UTC (permalink / raw)
To: notmuch; +Cc: tomi.ollila
From: Tomi Ollila <tomi.ollila@iki.fi>
in d27d90875dfb1 (2016-02-20) notmuch-mua-reply-insert-header-p-function
was set to notmuch-show-reply-insert-header-p-never as its default was
changed to something else. Now that default is set back to *-never so
this change done in d27d90875dfb1 is not needed anymore.
---
test/test-lib.el | 4 ----
1 file changed, 4 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index 02e020c..596a705 100644
--- a/test/test-lib.el
+++ b/test/test-lib.el
@@ -184,10 +184,6 @@ (defmacro notmuch-test-progn (&rest body)
(setq notmuch-tag-deleted-formats
'((".*" nil)))
-;; For historical reasonse we don't print part headers when replying
-;; in the tests suite
-(setq notmuch-mua-reply-insert-header-p-function 'notmuch-show-reply-insert-header-p-never)
-
;; force a common html renderer, to avoid test variations between
;; environments
--
1.9.3
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: Content-type of the mime part in cited text when replying
2016-03-15 12:04 ` David Edmondson
2016-03-15 12:07 ` Tomi Ollila
@ 2016-03-16 8:10 ` Nicolas Petton
1 sibling, 0 replies; 10+ messages in thread
From: Nicolas Petton @ 2016-03-16 8:10 UTC (permalink / raw)
To: David Edmondson, notmuch
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
David Edmondson <dme@dme.org> writes:
> On Tue, Mar 15 2016, Nicolas Petton wrote:
>> Hi,
>>
>> Using Notmuch from Melpa (build 20160314.1554), when replying to an
>> email, I get at the beginning of the citation the content-type of the
>> mime part. It looks like the following:
>>
>> John Doe <john@doe.com> writes:
>>
>> > [ text/plain ]
>> > hello there
>
> (setq notmuch-mua-reply-insert-header-p-function
> 'notmuch-show-reply-insert-header-p-never)
Ok, thanks.
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-03-26 12:11 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-15 9:59 Content-type of the mime part in cited text when replying Nicolas Petton
2016-03-15 12:04 ` David Edmondson
2016-03-15 12:07 ` Tomi Ollila
2016-03-15 12:11 ` David Edmondson
2016-03-16 8:23 ` Nicolas Petton
2016-03-16 8:57 ` Tomi Ollila
2016-03-18 21:25 ` David Bremner
2016-03-19 15:50 ` [PATCH] test/test-lib.el: revert setting notmuch-mua-reply-insert-header-p-function Tomi Ollila
2016-03-26 12:11 ` David Bremner
2016-03-16 8:10 ` Content-type of the mime part in cited text when replying Nicolas Petton
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).