From: Gaute Hope <eg@gaute.vetsj.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: talloc_abort in notmuch_thread_get_tags () when db has been modified
Date: Mon, 07 Mar 2016 09:14:00 +0000 [thread overview]
Message-ID: <1457341792-astroid-0-2wtydh6y1q-15951@strange> (raw)
In-Reply-To: <1453121100-astroid-2-c62fwcrm91-18877@strange>
Gaute Hope writes on January 18, 2016 13:45:
> David Bremner writes on January 18, 2016 13:25:
>> The most likely cause of such a crash looks to me like nm_thread is NULL
>> or corrupted when passed in to get_tags. It's used without checking as a
>> talloc context, and that call to talloc never returns.
>>
>
> Ok, I'll check some further. I am checking whether nm_thread is NULL
> though, [...]
Hi,
The stack trace that I get is as follows:
```
Stack trace of thread 15719:
#0 0x00007fc80cd9f2a8 raise (libc.so.6)
#1 0x00007fc80cda072a abort (libc.so.6)
#2 0x00007fc80c95889c n/a (libtalloc.so.2)
#3 0x00007fc80c95a02d talloc_named_const (libtalloc.so.2)
#4 0x00007fc814d674c5 _notmuch_string_list_create (libnotmuch.so.4)
#5 0x00007fc814d75f32 notmuch_thread_get_tags (libnotmuch.so.4)
#6 0x00000000004757cb _ZN7Astroid13NotmuchThread8get_tagsEP15_notmuch_thread (astroid)
```
this happens when:
1) start a long running query loading in the background
2) modify the db enough for the query to get invalidated.
as far as I can see, there is _no_ way to catch this error without
completely crashing the application. I would have to isolate this code
in a separate process or trap SIGABRT (which is certainly messy).
Best regards, Gaute
next prev parent reply other threads:[~2016-03-07 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 12:45 talloc_abort in notmuch_thread_get_tags () when db has been modified Gaute Hope
2016-03-07 9:14 ` Gaute Hope [this message]
2016-03-07 12:01 ` David Bremner
2017-02-15 22:58 ` Gaute Hope
2017-02-17 12:28 ` David Bremner
2017-02-17 14:01 ` Gaute Hope
2017-02-17 15:35 ` David Bremner
2017-11-03 10:45 ` Gaute Hope
2017-11-03 12:02 ` Gaute Hope
2017-11-03 12:18 ` David Bremner
2017-11-03 12:50 ` Gaute Hope
-- strict thread matches above, loose matches on Subject: below --
2016-01-18 8:46 Gaute Hope
2016-01-18 12:25 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457341792-astroid-0-2wtydh6y1q-15951@strange \
--to=eg@gaute.vetsj.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).