From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 8E93B6DE0A87 for ; Sun, 14 Feb 2016 10:40:11 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.259 X-Spam-Level: X-Spam-Status: No, score=0.259 tagged_above=-999 required=5 tests=[AWL=-0.171, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vsqxC2mkQM-x for ; Sun, 14 Feb 2016 10:40:09 -0800 (PST) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by arlo.cworth.org (Postfix) with ESMTPS id 4AAED6DE0943 for ; Sun, 14 Feb 2016 10:40:09 -0800 (PST) Received: by mail-wm0-f66.google.com with SMTP id a4so7054786wme.3 for ; Sun, 14 Feb 2016 10:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Koxgd0++1sEJYQkhTv1AFH8BOMDtyJIXoheK/x3Dg6Y=; b=ngipv1y5xL/coDticOs0C2SX4pNAZI8kM/tWo9Go3dGG1Jw5O92f9E458ICJngITU6 rw1EMHTz84aL1UCsKYSndUNfKWtBqFkoUkvieNDACH3BY8COBfFebYQ2Uyb86QWKEeBZ WX2X5R3PAzmumHATC28QjScYVBLgBgz8C4Gc3EGL7myaGz7SZX5JqOAFc8uBrxH8jwh7 BCkW9q9mmF/KXHMnG7VZhsFGgQmPuTqWJgDtn/nbHqyNVZr1PrF5M8GU4S+JG6Vij0Sf 9dmX2+kYtM77MOUUwWCEtiEfrWcC4FeXhl7JnaETm2dALW0xCkr/toXOkthsdV+n0UPR 1j5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Koxgd0++1sEJYQkhTv1AFH8BOMDtyJIXoheK/x3Dg6Y=; b=IjLkj4BoTlsaAihg08DUkcdzSzliMPiLVIQ6l93bG+K/miXE84GVTbXaI27WdnpbSc dBjlgTQzHe+RXrhweYMO74jNCBQlY5CluJELXF+oXJcu1bzymHekPLHMQlAhWbE4MFYY uILArXE+PUMaOGUkIHTuHru8tKHrW+3UawaFeDHOfm74AUY0/ZSvs2m5pYBzYtylx0i0 eYVZJTpjyuHL8/W5wqGh/CPAc6LfsNCUhfgs4/Oiqv5mhrQLb7lXxtONe6xiQ99VHhJ6 sDtUm9KFajpDUFeV/po0PSsU103paq9V/pP0AyeOHCiACErcxGs+cgdQwP1578nTjZ+2 v+tQ== X-Gm-Message-State: AG10YOR+zV4KM5VGgfUqLd0mU1AveOsdrnh0g37vmgaH+JzOMHd0vqyqjSUbHERJGl00mA== X-Received: by 10.194.78.148 with SMTP id b20mr12002517wjx.71.1455475206202; Sun, 14 Feb 2016 10:40:06 -0800 (PST) Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) by smtp.gmail.com with ESMTPSA id k4sm12051424wmc.12.2016.02.14.10.40.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Feb 2016 10:40:05 -0800 (PST) From: Mark Walters To: notmuch@notmuchmail.org Subject: [PATCH v5 0/7] emacs: Improve the cited message included in replies Date: Sun, 14 Feb 2016 18:39:52 +0000 Message-Id: <1455475199-32622-1-git-send-email-markwalters1009@gmail.com> X-Mailer: git-send-email 2.1.4 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2016 18:40:11 -0000 This is a slight update and a rebase of this patch set (previous version at id:1446894276-7814-1-git-send-email-markwalters1009@gmail.com ) The only change from last time (apart from fixing rebasing to master) is the rewording of couple of minor comments inline with dme's review of the previous version. Although I am submitting it is primarily dme's series, with minor updates from me. One particular motivation for this series is that it fixes a long standing bug we have that replying to a message with an rfc822 part completely omits that part. It also fixes the bug whereby we don't include application/octet-stream parts which are actually text/plain (and thus are displayed in show mode). This series makes the reply code use the same code as the show code so everything works as expected: the reply buffer looks essentially the same as the show buffer. There is one slight difference: the user might want different part headers displayed when replying; both because the audience is different (a non-notmuch using recipient) and because the buttons don't "work" (you can't click on them to show or view a part). Dme and I disagree on which of these we would like to see so make that customisable. The key change is patch 3 which switches how reply works. Also note that patch 2 is almost all whitespace change as the changes modify the indentation. Best wishes Mark David Edmondson (6): emacs/show: Re-arrange determination if a part header is necessary emacs/show: Accommodate the lack of part header buttons emacs/mua: Generate improved cited text for replies emacs/show: Remove the 'no-buttons option of `notmuch-show-insert-bodypart' emacs/show: Make the insertion of part headers overridable. emacs/mua: Let user specify which parts get a header in citations. Mark Walters (1): test: fix the tests for the new reply code emacs/notmuch-mua.el | 60 ++++++++++----------- emacs/notmuch-show.el | 144 +++++++++++++++++++++++++++++++------------------- test/T310-emacs.sh | 32 +++++++++++ test/test-lib.el | 4 ++ 4 files changed, 156 insertions(+), 84 deletions(-) -- 2.1.4