From: Gaute Hope <eg@gaute.vetsj.com>
To: notmuch@notmuchmail.org
Subject: talloc_abort in notmuch_thread_get_tags () when db has been modified
Date: Mon, 18 Jan 2016 08:46:41 +0000 [thread overview]
Message-ID: <1453106256-astroid-0-0ubhau8qws-26019@strange> (raw)
In-Reply-To:
Hi,
a user of astroid [0] ran into a issue [1] (full trace at issue) where
reading a long query causes a talloc_abort in notmuch_thread_get_tags
(). 'notmuch new' is running at the same time, and most likely a thread
in the query has been modified since the query was done. Note that a
notmuch_thread_get_authors () call returns NULL without causing a full
crash. The code causing the crash is:
```
for (tags = notmuch_thread_get_tags (nm_thread);
notmuch_tags_valid (tags);
notmuch_tags_move_to_next (tags))
{
tag = notmuch_tags_get (tags); // tag belongs to tags
}
// or db.cc:508 in astroid/src.
```
while:
```
const char * auths = notmuch_thread_get_authors (nm_thread);
```
returns `NULL`, but does not crash.
Is there a way for me to handle this from the application side?
Admittedly I do keep query objects around for a while
(astroid/src/thread_index.cc:141), but in this case the issue would
probably occur anyway since it simply takes a long time to read the
query.
Regards, Gaute
[0] https://github.com/gauteh/astroid
[1] https://github.com/gauteh/astroid/issues/64
next reply other threads:[~2016-01-18 8:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 8:46 Gaute Hope [this message]
2016-01-18 12:25 ` talloc_abort in notmuch_thread_get_tags () when db has been modified David Bremner
-- strict thread matches above, loose matches on Subject: below --
2016-01-18 12:45 Gaute Hope
2016-03-07 9:14 ` Gaute Hope
2016-03-07 12:01 ` David Bremner
2017-02-15 22:58 ` Gaute Hope
2017-02-17 12:28 ` David Bremner
2017-02-17 14:01 ` Gaute Hope
2017-02-17 15:35 ` David Bremner
2017-11-03 10:45 ` Gaute Hope
2017-11-03 12:02 ` Gaute Hope
2017-11-03 12:18 ` David Bremner
2017-11-03 12:50 ` Gaute Hope
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453106256-astroid-0-0ubhau8qws-26019@strange \
--to=eg@gaute.vetsj.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).