From: Michal Sojka <sojkam1@fel.cvut.cz>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: [PATCH] emacs: Don't use nconc on quoted list
Date: Wed, 6 Jan 2016 22:28:45 +0100 [thread overview]
Message-ID: <1452115725-19650-1-git-send-email-sojkam1@fel.cvut.cz> (raw)
In-Reply-To: <87ziwiv1nx.fsf@steelpick.2x.cz>
As pointed out by David Bremner, Elisp manual says "A common pitfall
is to use a quoted constant list as a non-last argument to ‘nconc’."
Since this was the case in recently added code, we fix it here.
---
emacs/notmuch-mua.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 45a6daa..5462f54 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -322,8 +322,8 @@ modified. This function is notmuch addaptation of
(notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
(or switch-function (notmuch-mua-get-switch-function)))
(let ((headers
- ;; The following sexp is copied from `message-mail'
- (nconc
+ (append
+ ;; The following is copied from `message-mail'
`((To . ,(or to "")) (Subject . ,(or subject "")))
;; C-h f compose-mail says that headers should be specified as
;; (string . value); however all the rest of message expects
--
2.6.4
next prev parent reply other threads:[~2016-01-06 21:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 16:47 notmuch-message-mode initialization follow-up Michal Sojka
2016-01-02 16:47 ` [PATCH 1/3] emacs: Fix mail composition under Emacs 23 Michal Sojka
2016-01-05 2:33 ` David Bremner
2016-01-06 21:27 ` Michal Sojka
2016-01-06 21:28 ` Michal Sojka [this message]
2016-01-02 16:47 ` [PATCH 2/3] emacs: Refactor notmuch-mua-mail Michal Sojka
2016-01-02 16:47 ` [PATCH 3/3] emacs: Handle switch-function argument of notmuch-mua-mail Michal Sojka
2016-01-08 12:41 ` David Bremner
2016-01-02 18:20 ` notmuch-message-mode initialization follow-up Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452115725-19650-1-git-send-email-sojkam1@fel.cvut.cz \
--to=sojkam1@fel.cvut.cz \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).