From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v4 0/7] emacs: Improve the cited message included in replies
Date: Sat, 7 Nov 2015 11:04:29 +0000 [thread overview]
Message-ID: <1446894276-7814-1-git-send-email-markwalters1009@gmail.com> (raw)
This is a rebase and somewhat tweaked version of dme's series from last year
id:1399897769-26809-1-git-send-email-dme@dme.org
One particular motivation for this series is that it fixes a long
standing bug we have that replying to a message with an rfc822 part
completely omits that part. It also fixes the bug whereby we don't
include application/octet-stream parts which are actually text/plain
(and thus are displayed in show mode).
This series makes the reply code use the same code as the show code so
everything works as expected: the reply buffer looks essentially the
same as the show buffer.
There is one slight difference: the user might want different part
headers displayed when replying; both because the audience is
different (a non-notmuch using recipient) and because the buttons
don't "work" (you can't click on them to show or view a part).
Dme and I disagree on which of these we would like to see so make that
customisable.
The key change is patch 3 which switches how reply works. Also note
that patch 2 is almost all whitespace change as the changes modify the
indentation.
Best wishes
Mark
David Edmondson (6):
emacs/show: Re-arrange determination if a part header is necessary
emacs/show: Accommodate the lack of part header buttons
emacs/mua: Generate improved cited text for replies
emacs/show: Remove the 'no-buttons option of
`notmuch-show-insert-bodypart'
emacs/show: Make the insertion of part headers overridable.
emacs/mua: Let user specify which parts get a header in citations.
Mark Walters (1):
test: fix the tests for the new reply code
emacs/notmuch-mua.el | 60 ++++++++++-----------
emacs/notmuch-show.el | 141 +++++++++++++++++++++++++++++++-------------------
test/T310-emacs.sh | 32 ++++++++++++
test/test-lib.el | 4 ++
4 files changed, 155 insertions(+), 82 deletions(-)
--
2.1.4
next reply other threads:[~2015-11-07 11:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 11:04 Mark Walters [this message]
2015-11-07 11:04 ` [PATCH v4 1/7] emacs/show: Re-arrange determination if a part header is necessary Mark Walters
2016-02-09 20:28 ` David Edmondson
2015-11-07 11:04 ` [PATCH v4 2/7] emacs/show: Accommodate the lack of part header buttons Mark Walters
2016-02-09 20:29 ` David Edmondson
2015-11-07 11:04 ` [PATCH v4 3/7] emacs/mua: Generate improved cited text for replies Mark Walters
2016-02-09 20:30 ` David Edmondson
2015-11-07 11:04 ` [PATCH v4 4/7] emacs/show: Remove the 'no-buttons option of `notmuch-show-insert-bodypart' Mark Walters
2016-02-09 20:31 ` David Edmondson
2015-11-07 11:04 ` [PATCH v4 5/7] emacs/show: Make the insertion of part headers overridable Mark Walters
2016-02-09 20:32 ` David Edmondson
2015-11-07 11:04 ` [PATCH v4 6/7] emacs/mua: Let user specify which parts get a header in citations Mark Walters
2016-02-09 20:34 ` David Edmondson
2016-02-09 22:35 ` Mark Walters
2016-02-10 8:07 ` David Edmondson
2015-11-07 11:04 ` [PATCH v4 7/7] test: fix the tests for the new reply code Mark Walters
2016-02-09 20:34 ` David Edmondson
2016-02-08 17:11 ` [PATCH v4 0/7] emacs: Improve the cited message included in replies David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446894276-7814-1-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).