unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH 3/3] completion: clean up top level completion
Date: Sat, 17 Oct 2015 19:30:03 +0300	[thread overview]
Message-ID: <1445099403-25998-3-git-send-email-jani@nikula.org> (raw)
In-Reply-To: <1445099403-25998-1-git-send-email-jani@nikula.org>

Add note about missing features.
---
 completion/notmuch-completion.bash | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/completion/notmuch-completion.bash b/completion/notmuch-completion.bash
index 1356c4a40515..f24d9ecd337f 100644
--- a/completion/notmuch-completion.bash
+++ b/completion/notmuch-completion.bash
@@ -484,10 +484,15 @@ _notmuch()
 
     if [ -z "${arg}" ]; then
 	# top level completion
-	local top_options="--help --version"
 	case "${cur}" in
-	    -*) COMPREPLY=( $(compgen -W "${top_options}" -- ${cur}) ) ;;
-	    *) COMPREPLY=( $(compgen -W "${_notmuch_commands}" -- ${cur}) ) ;;
+	    -*)
+		# XXX: handle ${_notmuch_shared_options} and --config=
+		local options="--help --version"
+		COMPREPLY=( $(compgen -W "${options}" -- ${cur}) )
+		;;
+	    *)
+		COMPREPLY=( $(compgen -W "${_notmuch_commands}" -- ${cur}) )
+		;;
 	esac
     elif [ "${arg}" = "help" ]; then
 	# handle help command specially due to _notmuch_commands usage
-- 
2.1.4

  parent reply	other threads:[~2015-10-17 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-26 11:12 [PATCH] completion: handle notmuch address --deduplicate= option Jani Nikula
2015-10-17 16:30 ` [PATCH 1/3] completion: complete notmuch count --lastmod Jani Nikula
2015-10-17 16:30   ` [PATCH 2/3] completion: complete shared options for each command Jani Nikula
2015-10-17 16:30   ` Jani Nikula [this message]
2015-10-17 21:03     ` [PATCH] completion: complete lastmod: search prefix Jani Nikula
2015-10-22 12:56       ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445099403-25998-3-git-send-email-jani@nikula.org \
    --to=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).